Skip to content

Fix warnings around TransactionWorkspaceMetaStoreManager #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snazy merged 1 commit into from
Nov 18, 2025
Merged

Fix warnings around TransactionWorkspaceMetaStoreManager #3044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisSecretsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ PrincipalSecretsResult resetPrincipalSecrets(
* @param clientId principal client id
* @param principalId id of the principal whose secrets should be deleted
*/
@Nonnull
void deletePrincipalSecrets(
@Nonnull PolarisCallContext callCtx, @Nonnull String clientId, long principalId);
}
1 change: 0 additions & 1 deletion polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisEventManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import org.apache.polaris.core.persistence.BasePersistence;

public interface PolarisEventManager {
@Nonnull
default void writeEvents(
@Nonnull PolarisCallContext callCtx, @Nonnull List<PolarisEvent> polarisEvents) {
BasePersistence ms = callCtx.getMetaStore();
Expand Down
2 changes: 1 addition & 1 deletion ...re/src/main/java/org/apache/polaris/core/persistence/AtomicOperationMetaStoreManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@ private void revokeGrantRecord(

/** {@inheritDoc} */
@Override
public @Nonnull void deletePrincipalSecrets(
public void deletePrincipalSecrets(
@Nonnull PolarisCallContext callCtx, @Nonnull String clientId, long principalId) {
// get metastore we should be using
BasePersistence ms = callCtx.getMetaStore();
Expand Down
Loading