Skip to content

made the regex more generic #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flyrain merged 8 commits into from
Nov 7, 2025
Merged

made the regex more generic #3005

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa7b282
made the regex more generic
cccs-cat001 Nov 7, 2025
c340ab3
cleanup aisle 2
cccs-cat001 Nov 7, 2025
bd2c3f8
updated ROLE_ARN_PATTERN comment
cccs-cat001 Nov 7, 2025
79fd424
removed test-case that would not be considered valid
cccs-cat001 Nov 7, 2025
ec4eb9a
Added this change to the changelog
cccs-cat001 Nov 7, 2025
9dc3aee
added a test case
cccs-cat001 Nov 7, 2025
101fcf3
added more tests for s3 ARN
cccs-cat001 Nov 7, 2025
2e0a1b9
tests work properly
cccs-cat001 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public static ImmutableAwsStorageConfigurationInfo.Builder builder() {

// Technically, it should be ^arn:(aws|aws-cn|aws-us-gov):iam::(\d{12}):role/.+$,
@JsonIgnore
public static final String ROLE_ARN_PATTERN = "^arn:(aws|aws-us-gov):iam::(\\d{12}):role/.+$";
public static final String ROLE_ARN_PATTERN = "^.+:(.*):iam:.*:(.*):role/.+$";
Comment thread
cccs-cat001 marked this conversation as resolved.
Outdated

private static final Pattern ROLE_ARN_PATTERN_COMPILED = Pattern.compile(ROLE_ARN_PATTERN);

Expand Down
Loading