Skip to content

Comments

Docs: Fix regtest doc#2955

Merged
MonkeyCanCode merged 1 commit intoapache:mainfrom
MonkeyCanCode:fix_doc_python3.9
Nov 3, 2025
Merged

Docs: Fix regtest doc#2955
MonkeyCanCode merged 1 commit intoapache:mainfrom
MonkeyCanCode:fix_doc_python3.9

Conversation

@MonkeyCanCode
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode commented Nov 1, 2025

  1. Change outdated docker command to make client-regenerate
  2. Remove reference for python3.9 as that is removed from Python client: remove Python 3.9 support #2795

@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Nov 1, 2025
@MonkeyCanCode MonkeyCanCode changed the title Fix regtest doc Docs: Fix regtest doc Nov 1, 2025
singhpk234
singhpk234 approved these changes Nov 1, 2025
View reviewed changes
Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @MonkeyCanCode !
can you please double confirm running the regtests that they work post this

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 1, 2025
@MonkeyCanCode
Copy link
Contributor Author

MonkeyCanCode commented Nov 1, 2025

Will do. I haven't do for this one as it was only doc change.

LGTM Thanks @MonkeyCanCode !
can you please double confirm running the regtests that they work post this

@MonkeyCanCode
Copy link
Contributor Author

MonkeyCanCode commented Nov 1, 2025

Will do. I haven't do for this one as it was only doc change.

LGTM Thanks @MonkeyCanCode !
can you please double confirm running the regtests that they work post this

hi @singhpk234, so if u tried to run the test locally (either with/without docker), it will always failed if u don't have the latest image built locally. This is because the docker file is now pointing to latest from dockerhub (version 1.2.0) but there is one breaking change on their build and it got fixed by @flyrain last week via https://github.com/apache/polaris/pull/2854/files (in this one, POST /v1/{prefix}/transactions/commit got print twice from catalog config). However, if u run the change with the local image (latest main), you will be able to get completed build:

regtest-1 exited with code 0

This has nothing to do with the changes in this PR. let me know if you have any concern before the merge.
cc. @flyrain

Thanks,
Yong

singhpk234
singhpk234 approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for checking and the code change @MonkeyCanCode

@MonkeyCanCode MonkeyCanCode merged commit 673dfb1 into apache:main Nov 3, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 3, 2025
snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025
@snazy @renovate-bot
@MonkeyCanCode @tmater
Dremio merge 2025 11 03 17 08 (apache#152)
75f38c6 
* Update dependency com.fasterxml.jackson:jackson-bom to v2.20.1 (apache#2949)

* Update dependency com.github.jk1:gradle-license-report to v3 (apache#2958)

* Fix typos and spelling issues identified by codespell (apache#2959)

* Fix findings with codespell

* Fix findings with codespell

* Fix regtest doc (apache#2955)

* fix(deps): update dependency software.amazon.awssdk:bom to v2.37.3 (apache#2960)

* Refactor Polaris cloudTests and adopt changes from PR apache#2405 (apache#2871)

* Last merged commit 4a80c51

---------

Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: Yong Zheng <yongzheng0809@gmail.com>
Co-authored-by: Tamas Mate <50709850+tmater@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

@singhpk234 singhpk234 singhpk234 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MonkeyCanCode @ebyhr @singhpk234