Root POM: link to project's LICENSE, add NOTICE+DISCLAIMER to comment#2911
Root POM: link to project's LICENSE, add NOTICE+DISCLAIMER to comment#2911snazy wants to merge 1 commit intoapache:mainfrom
Conversation
snazy
force-pushed
the
license-link-github
branch
from
b1f5cb2 to
6c3231c
Compare
This change replaces the project's license URL in the parent POM from the AL-2.0 template to the `LICENSE` file in the project's root directory.
Before (in `pom.xml`):
```
<licenses>
<license>
<name>Apache-2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
</license>
</licenses>
```
With this change:
```
<licenses>
<license>
<name>Apache-2.0</name>
<url>https://raw.githubusercontent.com/apache/polaris/HEAD/LICENSE</url>
<comments>NOTICE: https://raw.githubusercontent.com/apache/polaris/HEAD/NOTICE
DISCLAIMER: https://raw.githubusercontent.com/apache/polaris/HEAD/DISCLAIMER</comments>
</license>
</licenses>
```
snazy
force-pushed
the
license-link-github
branch
from
6c3231c to
6a74201
Compare
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
| comments.set( | ||
| """ | ||
| NOTICE: ${gitInfo.rawGithubLink("NOTICE")} | ||
| DISCLAIMER: ${gitInfo.rawGithubLink("DISCLAIMER")} |
There was a problem hiding this comment.
Adding these links for release builds sounds valuable to me, but given current impl. of GitInfo for non-release builds (using HEAD) I do not think the links would be useful or even correct.
Could we identity whether GetInfo has a solid tag and avoid adding links if it does not?
There was a problem hiding this comment.
The link would be correct (e.g. https://raw.githubusercontent.com/apache/polaris/$rawLinkRef/$file translates to https://raw.githubusercontent.com/apache/polaris/HEAD/LICENSE) in case it's not a release.
I don't see a better alternative than HEAD here for non-release builds, as the Git commit SHA could be from "anywhere".
However, the referenced files are probably not the right ones for the root pom.
Hm - maybe let's drop this PR. I'll leave it open for a bit, but it looks like it's incorrect.
|
Let's abandon this PR. |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
3 participants
This change replaces the project's license URL in the parent POM from the AL-2.0 template to the
LICENSEfile in the project's root directory.Before (in
pom.xml):With this change: