Skip to content

Conversation

@adutra
Copy link
Contributor

@adutra adutra commented Sep 6, 2024

Description

Build is failing when property eclipseLink is true:

./gradlew clean build -PeclipseLink=true
> Task :polaris-service:generateLicenseReport FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':polaris-service:generateLicenseReport'.
> License information for the following artifacts is missing in the root LICENSE file: 

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • ./gradlew clean build -PeclipseLink=true now passes

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue



---
com.sun.xml.bind:jaxb-xjc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just move this like below line 1352, if the license is exactly the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it doesn't look the same, on line 2371 there is a mention Copyright (c) 2004 Kohsuke Kawaguchi that is not present in jaxb-core license.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

permitted.

---
jakarta.xml.bind:jakarta.xml.bind-api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - the licenses for Jakarta look the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see that are divergences:

jakarta.annotation:jakarta.annotation-api
jakarta.el:jakarta.el-api
jakarta.servlet:jakarta.servlet-api
jakarta.ws.rs:jakarta.ws.rs-api

  => EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0

jakarta.xml.bind:jakarta.xml.bind-api

  => BSD-3-Clause (+Oracle preamble?)

jakarta.persistence:jakarta.persistence-api (new)

  => EPL-2.0 OR BSD-3-Clause

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@snazy snazy merged commit d3cdb1c into apache:main Sep 6, 2024
@adutra adutra deleted the fix-license-report branch September 6, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants