Skip to content

Remove DROP statements from SQL init scripts #2565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adutra merged 1 commit into from
Sep 15, 2025
Merged

Remove DROP statements from SQL init scripts #2565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions persistence/relational-jdbc/src/main/resources/h2/schema-v3.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ MERGE INTO version (version_key, version_value)
-- H2 supports COMMENT, but some modes may ignore it
COMMENT ON TABLE version IS 'the version of the JDBC schema in use';

DROP TABLE IF EXISTS entities;
Copy link
Contributor

@dimas-b dimas-b Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is worth mentioning in CHANGELOG.md, WDYT?

Copy link
Contributor Author

@adutra adutra Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will tackle that as a follow-up PR.

CREATE TABLE IF NOT EXISTS entities (
realm_id TEXT NOT NULL,
catalog_id BIGINT NOT NULL,
Expand Down Expand Up @@ -80,7 +79,6 @@ COMMENT ON COLUMN entities.properties IS 'entities properties json';
COMMENT ON COLUMN entities.internal_properties IS 'entities internal properties json';
COMMENT ON COLUMN entities.grant_records_version IS 'the version of grant records change on the entity';

DROP TABLE IF EXISTS grant_records;
CREATE TABLE IF NOT EXISTS grant_records (
realm_id TEXT NOT NULL,
securable_catalog_id BIGINT NOT NULL,
Expand All @@ -98,7 +96,6 @@ COMMENT ON COLUMN grant_records.grantee_catalog_id IS 'catalog id of the grantee
COMMENT ON COLUMN grant_records.grantee_id IS 'id of the grantee';
COMMENT ON COLUMN grant_records.privilege_code IS 'privilege code';

DROP TABLE IF EXISTS principal_authentication_data;
CREATE TABLE IF NOT EXISTS principal_authentication_data (
realm_id TEXT NOT NULL,
principal_id BIGINT NOT NULL,
Expand All @@ -111,7 +108,6 @@ CREATE TABLE IF NOT EXISTS principal_authentication_data (

COMMENT ON TABLE principal_authentication_data IS 'authentication data for client';

DROP TABLE IF EXISTS policy_mapping_record;
CREATE TABLE IF NOT EXISTS policy_mapping_record (
realm_id TEXT NOT NULL,
target_catalog_id BIGINT NOT NULL,
Expand Down
1 change: 0 additions & 1 deletion persistence/relational-jdbc/src/main/resources/postgres/schema-v3.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ CREATE TABLE IF NOT EXISTS principal_authentication_data (

COMMENT ON TABLE principal_authentication_data IS 'authentication data for client';

DROP TABLE IF EXISTS policy_mapping_record;
CREATE TABLE IF NOT EXISTS policy_mapping_record (
realm_id TEXT NOT NULL,
target_catalog_id BIGINT NOT NULL,
Expand Down