Inject PolarisAdminService into PolarisServiceImpl #2533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
force-pushed
the
inject-PolarisAdminService
branch
from
f53eed0 to
67a272a
Compare
XN137
commented
Sep 10, 2025
| import jakarta.annotation.Nonnull; | ||
| import org.apache.polaris.core.PolarisCallContext; | ||
| import org.apache.polaris.core.persistence.dao.entity.PrincipalSecretsResult; | ||
| import software.amazon.awssdk.annotations.NotNull; |
XN137
commented
Sep 10, 2025
| */ | ||
| private boolean requiresSecretReferenceExtraction( | ||
| @NotNull ConnectionConfigInfo connectionConfigInfo) { | ||
| @Nonnull ConnectionConfigInfo connectionConfigInfo) { |
Contributor
Author
There was a problem hiding this comment.
needed to be changed as quarkus thought this might be a rest endpoint or the like, quite sure Nonnull was the original intent (i.e. not validation here)
XN137
commented
Sep 10, 2025
| private PolarisAdminService newAdminService( | ||
| RealmContext realmContext, SecurityContext securityContext) { | ||
| PolarisPrincipal authenticatedPrincipal = (PolarisPrincipal) securityContext.getUserPrincipal(); | ||
| if (authenticatedPrincipal == null) { |
Contributor
Author
There was a problem hiding this comment.
note that this checks happens in PolarisAdminService ctor already
XN137
commented
Sep 10, 2025
| @@ -172,7 +126,6 @@ private static Response toResponse(BaseResult result, Response.Status successSta | |||
| @Override | |||
| public Response createCatalog( | |||
| CreateCatalogRequest request, RealmContext realmContext, SecurityContext securityContext) { | |||
Contributor
Author
There was a problem hiding this comment.
the realmContext and securityContext params in these methods are now all unused.
note that since this class has a CallContext field, we can be sure that realmContext is matching the one from the injected request-scoped fields.
wondering:
should we adjust openapi server-templates to remove one/both from the apis (now/in a followup)?
Contributor
There was a problem hiding this comment.
I'd say remove in a follow-up.
Contributor
There was a problem hiding this comment.
+1 on follow-up, the same should apply to IcebergAdapter, GenericTableAdapter and PolicyAdapter. I think the server template update will not be a small PR
dimas-b
approved these changes
Sep 10, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
HonahX
approved these changes
Sep 10, 2025
| @@ -172,7 +126,6 @@ private static Response toResponse(BaseResult result, Response.Status successSta | |||
| @Override | |||
| public Response createCatalog( | |||
| CreateCatalogRequest request, RealmContext realmContext, SecurityContext securityContext) { | |||
Contributor
There was a problem hiding this comment.
+1 on follow-up, the same should apply to IcebergAdapter, GenericTableAdapter and PolicyAdapter. I think the server template update will not be a small PR
`PolarisServiceImpl` already is a request-scoped bean. if we apply the same to `PolarisAdminService` we can simply inject it into `PolarisServiceImpl`.
XN137
force-pushed
the
inject-PolarisAdminService
branch
from
67a272a to
5a46a7d
Compare
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* Fix deprecation warnings in GcpCredentialsStorageIntegrationTest (apache#2544) * Fix deprecation warnings in GcpCredentialsStorageIntegrationTest Refactor the code to use an explicit InputStream Cf. FasterXML/jackson-core#803 * Add subtype-check to PolarisEntity subclass ctors (apache#2492) this is a follow-up to ac31963 * Inject PolarisAdminService into PolarisServiceImpl (apache#2533) `PolarisServiceImpl` already is a request-scoped bean. if we apply the same to `PolarisAdminService` we can simply inject it into `PolarisServiceImpl`. * Reduce getOrCreateMetaStoreManager callers (apache#2532) we can inject `PolarisMetaStoreManager` directly into request-scoped beans or build it only once in tests that operate in a single realm. * Update dependency mypy to >=1.18, <=1.18.1 (apache#2547) * Update dependency pyiceberg to v0.10.0 (apache#2549) Co-authored-by: Yong Zheng <[email protected]> * Minor fix for README.md (apache#2558) * Testing: Let runtime-service tests use Quarkus via `enforcedPlatform()` (apache#2545) This change ensures that the tests in runtime-service use the same Quarkus platform dependency versions as Polaris server does. * Update quay.io/keycloak/keycloak Docker tag to v26.3.4 (apache#2553) * Update dependency software.amazon.awssdk:bom to v2.33.9 (apache#2561) * NoSQL: remove unused type * Last merged commit a2f29cb * disable flaky test apache#2563 --------- Co-authored-by: Dmitri Bourlatchkov <[email protected]> Co-authored-by: Christopher Lambert <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Yong Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PolarisServiceImplalready is a request-scoped bean. if we apply the same toPolarisAdminServicewe can simply inject it intoPolarisServiceImpl.