-
Notifications
You must be signed in to change notification settings - Fork 365
Built: improve reproducible archive files #2432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,7 @@ plugins { | |
| `jvm-test-suite` | ||
| checkstyle | ||
| id("polaris-spotless") | ||
| id("polaris-reproducible") | ||
| id("jacoco-report-aggregation") | ||
| id("net.ltgt.errorprone") | ||
| } | ||
|
|
@@ -237,9 +238,20 @@ configurations.all { | |
| } | ||
| } | ||
|
|
||
| // ensure jars conform to reproducible builds | ||
| // (https://docs.gradle.org/current/userguide/working_with_files.html#sec:reproducible_archives) | ||
| tasks.withType<AbstractArchiveTask>().configureEach { | ||
| isPreserveFileTimestamps = false | ||
| isReproducibleFileOrder = true | ||
| if (plugins.hasPlugin("io.quarkus")) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it be worth moving it to
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have a dedicated build-plugin for the "distributed" Quarkus builds, but also other projects that use/build with Quarkus.... So I put it into the non-java version specific one. |
||
| tasks.named("quarkusBuild") { | ||
| actions.addLast { | ||
| listOf( | ||
| "quarkus-app/quarkus-run.jar", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does Quarkus not respect
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ehm - nope. That's a Gradle thing. |
||
| "quarkus-app/quarkus/generated-bytecode.jar", | ||
| "quarkus-app/quarkus/transformed-bytecode.jar", | ||
| ) | ||
| .forEach { name -> | ||
| val file = project.layout.buildDirectory.get().file(name).asFile | ||
| if (file.exists()) { | ||
| makeZipReproducible(file) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| // ensure jars conform to reproducible builds | ||
| // (https://docs.gradle.org/current/userguide/working_with_files.html#sec:reproducible_archives) | ||
| tasks.withType<AbstractArchiveTask>().configureEach { | ||
| isPreserveFileTimestamps = false | ||
| isReproducibleFileOrder = true | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ | |
|
|
||
| plugins { | ||
| `java-library` | ||
| id("polaris-reproducible") | ||
| } | ||
|
|
||
| description = "Polaris site - reference docs" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
0😉There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gradle uses the same timestamp. IIRC it's got something to do with ZIP file format specialties...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok 👍