Update changelog prior to 1.1.0 release #2406
Conversation
pingtimeout
changed the title
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
I think there's a misunderstanding about what "breaking changes" are.
I don't mind to add another heading "Improvements" in addition to "Highlights", but most of the points in "breaking changes" are not breaking changes.
pingtimeout
left a comment
pingtimeout
left a comment
There was a problem hiding this comment.
@snazy thanks for the review, I am going to address some of them. But I want to give you a heads up about Github misleading UI. When people review the changelog, L45-L50 are collapsed, which makes it look like all the items added under ### New Feature were actually added to ### Breaking changes. But this is not the case. See attached screenshot.
Co-authored-by: Robert Stupp <[email protected]>
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for compiling this update @pingtimeout !
In the future let's try to proactively update CHANGELOG.md in PRs that are worth mentioning :)
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Ah, yes, you're right. Ignore me. |
|
@pingtimeout : heads up: merge conflict 😅 |
CHANGELOG.md
Outdated
|
|
||
| - Introduced S3 path-style access support for improved compatibility with S3-compatible storage systems. | ||
|
|
||
| - Added MinIO integration support with comprehensive getting started documentation. |
There was a problem hiding this comment.
Should we put this in the highlight section? I think this is a big thing for people using s3-compatible storage.
There was a problem hiding this comment.
I'm ok to move this to highlights, but s3-compatible support is not yet complete because of #2207... ATM, MinIO works, but systems without STS are not easy to use 🤷
flyrain
left a comment
flyrain
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the update, @pingtimeout !
|
Thanks for the review. I just resolved the merge conflicts and moved the MinIO bullet point under highlights. Now waiting for CI... |
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
* feat: enforce LIST_PAGINATION_ENABLED (apache#2401) * feat: enforce LIST_PAGINATION_ENABLED The enforcement of the LIST_PAGINATION_ENABLED flag was missed in apache#1938. This change make the flag effective as discussed in apache#2296. Note: this causes a change in the default Polaris behaviour (no pagination by default) with respect to the previous state of `main`. However, there is no behaviour change with respect to 1.0.0 or 1.0.1 as previous releases did not have apache#1938. * Add PolarisMetaStoreManager.loadEntities (apache#2290) * Add PolarisMetaStoreManager.loadEntities currently `PolarisMetaStoreManager.listEntities` only exposes a limited subset of the underlying `BasePersistence.listEntities` functionality. most of the callers have to post-process the `EntityNameLookupRecord` of `ListEntitiesResult` and call `PolarisMetaStoreManager.loadEntity` on the individual items sequentually to transform and filter them. this is bad for the following reasons: - suboptimal performance as we run N+1 queries to basically load every entity twice from the persistence backend - suffering from race-conditions when entities get dropped between the `listEntities` and `loadEntity` call - a lot of repeated code in all the callers (of which only some are dealing with the race-condition by filtering out null values) as a solution we add `PolarisMetaStoreManager.loadEntities` that takes advantage of the already existing `BasePersistence` methods. we rename one of the `listEntities` methods to `loadEntities` for consistency. since many callers dont need paging and want the result as a list, we add `PolarisMetaStoreManager.loadEntitiesAll` as a convenient wrapper. we also remove the `PolarisEntity.nameAndId` method as callers who only need name and id should not be loading the full entity to begin with. note we rework `testCatalogNotReturnedWhenDeletedAfterListBeforeGet` from `ManagementServiceTest` because the simulated race-condition scenario can no longer happen. * review: remove filter + transformer params * review: add TODO in listPolicies * review: improve javadoc * chore: fix Page javadoc (apache#2412) Correct method args (follow-up to apache#2401) * Add 1.0.1-incubating release blog post (apache#2403) * This change fixes: (apache#2395) * use [email protected] for announcement * publish Docker images only when the vote passed (we are not suppose to publish any public artifacts before the vote is completed) * update the vote email accordingly * remove blog post link in the release announcement email to let this to the discretion of the release manager * chore(deps): update actions/setup-java action to v5 (apache#2414) * chore(test): Restore PolarisAccessManager (apache#2413) Restore `PolarisAccessManager` (with default implementation of `IcebergTokenAccessManager`) which was added as an extension point for running Polaris tests in downstream build environments under apache#789, but was mistakenly removed in apache#2343 * Update changelog prior to 1.1.0 release (apache#2406) * fix(deps): update quarkus platform and group to v3.25.4 (apache#2279) * NoSQL: merge related changes * Last merged commit 82cd416 --------- Co-authored-by: Dmitri Bourlatchkov <[email protected]> Co-authored-by: Christopher Lambert <[email protected]> Co-authored-by: JB Onofré <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Pierre Laporte <[email protected]>
5 participants
Command to list all commits that were added to
mainand that are not already included in 1.1.0: