Skip to content

Fix compilation warnings in AzureCredentialStorageIntegrationTest #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adutra merged 1 commit into from
Aug 1, 2025
Merged

Fix compilation warnings in AzureCredentialStorageIntegrationTest #2231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .../java/org/apache/polaris/service/storage/azure/AzureCredentialStorageIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.ArgumentsProvider;
import org.junit.jupiter.params.provider.ArgumentsSource;
import org.junit.jupiter.params.support.ParameterDeclarations;

public class AzureCredentialStorageIntegrationTest extends BaseStorageIntegrationTest {

Expand Down Expand Up @@ -115,7 +116,7 @@ public void testGetSubscopedTokenList(boolean allowListAction, String service) {

boolean isBlobService = service.equals("blob");
List<String> allowedLoc =
Arrays.asList(
List.of(
String.format(
"abfss://container@icebergdfsstorageacct.%s.core.windows.net/polaris-test/",
service));
Expand Down Expand Up @@ -186,7 +187,7 @@ public void testGetSubscopedTokenRead(
String allowedPrefix = "polaris-test";
String blockedPrefix = "blocked-prefix";
List<String> allowedLoc =
Arrays.asList(
List.of(
String.format(
"abfss://container@icebergdfsstorageacct.%s.core.windows.net/%s",
service, allowedPrefix));
Expand Down Expand Up @@ -256,7 +257,7 @@ public void testGetSubscopedTokenWrite(
String allowedPrefix = "polaris-test/scopedcreds/";
String blockedPrefix = "blocked-prefix";
List<String> allowedLoc =
Arrays.asList(
List.of(
String.format(
"abfss://container@icebergdfsstorageacct.%s.core.windows.net/%s",
service, allowedPrefix));
Expand Down Expand Up @@ -401,7 +402,8 @@ private DataLakeFileClient createDatalakeFileClient(

protected static class AzureTestArgs implements ArgumentsProvider {
@Override
public Stream<? extends Arguments> provideArguments(ExtensionContext extensionContext) {
public Stream<? extends Arguments> provideArguments(
ParameterDeclarations parameterDeclarations, ExtensionContext extensionContext) {
return Stream.of(
Arguments.of(/* allowedList= */ true, "blob"),
Arguments.of(/* allowedList= */ false, "blob"),
Expand Down