Skip to content

Fix CLI error polaris: not found #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eric-maynard wants to merge 2 commits into from
Closed

Fix CLI error polaris: not found #2228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c0e05
fix
eric-maynard Aug 1, 2025
02c8967
revert mode change
eric-maynard Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion polaris
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,4 @@ if [ -z "$VIRTUAL_ENV" ] || [ "$(realpath "$VIRTUAL_ENV")" != "$(realpath "${dir
fi

export SCRIPT_DIR="${dir}"
exec polaris "$@"
env PYTHONPATH=client/python SCRIPT_DIR="$dir" "${dir}"/polaris-venv/bin/python3 client/python/cli/polaris_cli.py "$@"
Copy link
Contributor

@MonkeyCanCode MonkeyCanCode Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should work as it is now using the installed package instead of invoking the class directly. Do we have a reproducible or I can take a closer look a bit later this weekend (assuming the user removes the old virtualenv and setup the new one)

Copy link
Contributor

@MonkeyCanCode MonkeyCanCode Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eric-maynard

I think it may be better to ask users to run polaris --repair instead add back the original code above as this will be a blocker for us to move away from polaris bash script:

➜  polaris git:(main) ./polaris --repair

➜  polaris git:(main) ./polaris
Traceback (most recent call last):
  File "/Users/yong/Desktop/GitHome/test/polaris/polaris-venv/bin/polaris", line 6, in <module>
    sys.exit(main())
             ~~~~^^
  File "/Users/yong/Desktop/GitHome/test/polaris/client/python/cli/polaris_cli.py", line 219, in main
    PolarisCli.execute()
    ~~~~~~~~~~~~~~~~~~^^
  File "/Users/yong/Desktop/GitHome/test/polaris/client/python/cli/polaris_cli.py", line 70, in execute
    client_builder = PolarisCli._get_client_builder(options)
  File "/Users/yong/Desktop/GitHome/test/polaris/client/python/cli/polaris_cli.py", line 175, in _get_client_builder
    raise Exception(
    ...<5 lines>...
    )
Exception: Please provide credentials via either --client-id & --client-secret or --access-token. Alternatively, you may set the environment variables CLIENT_ID & CLIENT_SECRET.

➜  polaris git:(main) cat polaris | grep exec
exec polaris "$@"

Copy link
Contributor Author

@eric-maynard eric-maynard Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me ask, good idea. Separately, IIUC the podman requirement can go away in the future too?

Copy link
Contributor

@MonkeyCanCode MonkeyCanCode Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podman (docker) requirement for codegen via openapi? If yes, it is already addressed in #2192 but pending for review.

Loading