-
Notifications
You must be signed in to change notification settings - Fork 357
Remove CallContext.CURRENT_CONTEXT #2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eedeb05 to
5ec6bf4
Compare
5ec6bf4 to
9188d6c
Compare
adutra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent news 😄
snazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!!!
dimas-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to finally remove thread locals 👍
* Simplify BaseMetaStoreManager.extractStorageConfiguration (apache#2194) as a static helper method its strongly preferable to not depend on the full `PolarisCallContext` if not necessary. * Remove PolarisCallContext from TreeMapMetaStore (apache#2195) * remove PolarisCallContext from TreeMapMetaStore methods * reset diagnosticServices in TreeMapMetaStore * simplify ensure methods * Remove getCurrentContext from InMemoryStorageIntegration (apache#2201) * Remove getCurrentContext from JWTBroker (apache#2202) * fix(deps): update dependency boto3 to v1.39.17 (apache#2211) * fix(deps): update dependency org.apache.commons:commons-compress to v1.28.0 (apache#2212) * Enable python client debug flag (apache#2154) * Enable python client debug flag * Move debug msg to stderr and move debug enable after option parsing * Remove postgres_latest as image tag (apache#2045) * Remove postgres_latest as image tag * Change image tag to latest for getting started examples * Change image tag to latest from helm * fix(deps): update dependency io.smallrye.common:smallrye-common-annotation to v2.13.8 (apache#2222) * Remove CallContextResolver (apache#2215) it seems like these were unused leftovers from previous changes * Replace CommitFailedException with CommitConflictException (apache#2198) * Replace CommitFailedException with CommitConflictException In some cases, we were using CommitFailedException to represent commit conflicts, which returns the correct 409 response but is tied to Iceberg. However, some of these conflicts originate from Polaris, making CommitConflictException a more appropriate and accurate choice. This change updates those instances to improve clarity and exception handling semantics. Resolves apache#2168 * JDBC: Include error code + SQL state in exception messages (apache#2220) * fix(deps): update dependency boto3 to v1.40.0 (apache#2225) * chore(deps): update actions/stale digest to 8f717f0 (apache#2224) * Fix Awaitility build configuration (apache#2232) * Fix compilation warnings in AzureCredentialStorageIntegrationTest (apache#2231) * Remove CallContext.CURRENT_CONTEXT (apache#2203) the last callers of `CallContext.getCurrentContext` had been removed in the following commits: - 756e535 - e7eb59f - 4d94745 thus we can now remove the `CURRENT_CONTEXT` threadlocal and all associated methods. * NoSQL: adoptions & cosmetics * Last merged commit 0449d9b --------- Co-authored-by: Christopher Lambert <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Yong Zheng <[email protected]> Co-authored-by: Tamas Mate <[email protected]> Co-authored-by: Alexandre Dutra <[email protected]>
the last callers of
CallContext.getCurrentContexthad beenremoved in the following commits:
thus we can now remove the
CURRENT_CONTEXTthreadlocal and allassociated methods.