-
Notifications
You must be signed in to change notification settings - Fork 351
client/python: loosen boto3 dep #2188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's hard to depend on this package when the boto3 dependency is so strict.
XN137
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me
snazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renovate would bump the version anyways to the latest, so >= would effectively mean the same as '==`.
I guess a version range would help here. But not sure what a "good compatible range" for boto would be (I'm not that familiar w/ the Python ecosystem).
|
Boto3 is a pretty stable library. We could use ~= |
|
Closing |
Mind updating your PR? |
done |
|
Ping @snazy |
|
LGTM! |
|
BTW @rockwotj can you fix the merge-conflict? |
done! |
|
@rockwotj thanks for the PR. change looks good. Please fix conflict when you get a chance then we can get this in. |
|
Thanks @MonkeyCanCode done. |
Thanks for the PR. |
* Helm Chart: remove duplicate line in authenticationOptions template (apache#2297) * Move python client Makefile into the root level one (apache#2140) * Move python client Makefile into the root level one * Update workflow * add client-lint to pre-commit * Update README.md to include client * fix(deps): update dependency boto3 to v1.40.5 (apache#2300) * fix(deps): update dependency org.assertj:assertj-core to v3.27.4 (apache#2298) * Fix python CI client-integration-test (apache#2305) `CONTAINER_TOOL` got renamed to `DOCKER` in 6764a88 but then eda7074 added more `CONTAINER_TOOL` usage * fix(docs): update BasePolarisAuthenticator to DefaultAuthenticator (apache#2303) * Fix Hadoop federation to initialize the configuration prior to catalog initialization (apache#2282) This PR addresses the gap in Hadoop federation to ensure that we initialize the hadoop configuration prior to initializing the catalog object. The iceberg library expects the hadoop configuration to be initialized before creating a HadoopCatalog object. This change ensures that Polaris is compatible with the underlying iceberg library. Additionally, since the config initialization is based on the underlying (default) core-site.xml file, the change ensures that the federated catalog was created using `IMPLICIT` authentication mode. Testing: Due to current limitations in the current test setup, tested the change manually. [TODO] Add a regtest with hadoop federation once the change is baked into the apache/polaris docker image. * fix(deps): update dependency boto3 to v1.40.6 (apache#2308) * fix(deps): update dependency io.opentelemetry:opentelemetry-bom to v1.53.0 (apache#2309) * Perform force repair when polaris not found (apache#2313) * fix(deps): update dependency com.github.spotbugs:spotbugs-annotations to v4.9.4 (apache#2312) * chore(deps): update dependency pre-commit to v4.3.0 (apache#2311) * fix(deps): update dependency software.amazon.awssdk:bom to v2.32.19 (apache#2314) * fix(deps): update dependency com.gradleup.shadow:shadow-gradle-plugin to v9.0.1 (apache#2310) * Separate Cloud Integration Tests (apache#2283) Currently, cloud integration tests are part of the regular test suite but require cloud credentials to execute properly. This creates unnecessary overhead for developers who just want to run local builds or for CI jobs that don't have cloud access configured. * chore(deps): update actions/checkout action to v5 (apache#2319) * CatalogEntity: internal endpoint not considered (apache#2292) Setting an S3 internal endpoint doesn't work, because the property's not carried over from the OpenAPI model type into `AwsStorageConfigInfo`. * client/python: loosen boto3 dep (apache#2188) It's hard to depend on this package when the boto3 dependency is so strict. * fix(deps): update dependency io.micrometer:micrometer-bom to v1.15.3 (apache#2321) * NoSQL: test adjustment * Last merged commit 45e8e02 --------- Co-authored-by: Alexandre Dutra <[email protected]> Co-authored-by: Yong Zheng <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Christopher Lambert <[email protected]> Co-authored-by: Yujiang Zhong <[email protected]> Co-authored-by: Pooja Nilangekar <[email protected]> Co-authored-by: Tamas Mate <[email protected]> Co-authored-by: Tyler Rockwood <[email protected]>
It's hard to depend on this package when the boto3 dependency is so strict.