Skip to content

Update Helm chart version #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flyrain merged 1 commit into from
Jun 27, 2025
+5 −3
Merged

Update Helm chart version #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions helm/polaris/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ apiVersion: v2
name: polaris
description: A Helm chart for Apache Polaris (incubating)
type: application
version: 0.1.0
appVersion: 1.0.0-incubating-SNAPSHOT
version: 1.1.0-incubating-SNAPSHOT
appVersion: 1.1.0-incubating-SNAPSHOT
home: https://polaris.apache.org/
icon: https://raw.githubusercontent.com/apache/polaris/main/site/static/img/logos/polaris-brandmark.png
sources:
Expand All @@ -36,3 +36,4 @@ maintainers:
- name: collado-mike
- name: gerrit-k
- name: snazy
- name: flyrain
Copy link
Contributor Author

@flyrain flyrain Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this maintainer list is needed. We didn't do that in somewhere else. Is it a Helm Chart thing?

Copy link
Contributor

@MonkeyCanCode MonkeyCanCode Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it is an optional field (ref: https://helm.sh/docs/topics/charts/):

maintainers: # (optional)
  - name: The maintainers name (required for each maintainer)
    email: The maintainers email (optional for each maintainer)
    url: A URL for the maintainer (optional for each maintainer)

Copy link
Contributor Author

@flyrain flyrain Jun 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. In that case, I'd propose to remove the list in a followup PR, as it adds maintenance burden, which makes it inaccurate inevitably. WDYT?

Copy link
Contributor

@MonkeyCanCode MonkeyCanCode Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think that is probably better in this case.

1 change: 1 addition & 0 deletions helm/polaris/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ A Helm chart for Apache Polaris (incubating).
* [collado-mike](https://github.com/collado-mike)
* [gerrit-k](https://github.com/gerrit-k)
* [snazy](https://github.com/snazy)
* [flyrain](https://github.com/flyrain)

## Source Code

Expand Down
2 changes: 1 addition & 1 deletion helm/polaris/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ image:
# -- The image pull policy.
pullPolicy: IfNotPresent
# -- The image tag.
tag: "latest"
tag: "1.1.0-incubating-SNAPSHOT"
# -- The path to the directory where the application.properties file, and other configuration
# files, if any, should be mounted.
# Note: if you are using EclipseLink, then this value must be at least two folders down to the
Expand Down
Loading