Skip to content

Exclude unused dependency for polaris spark client dependency #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-yzou merged 2 commits into from
Jun 25, 2025
Merged

Exclude unused dependency for polaris spark client dependency #1933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb9d620
trim unused pacakge dependency for spark client
gh-yzou Jun 24, 2025
e4c274b
update change
gh-yzou Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions plugins/spark/v3.5/spark/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,7 @@ val scalaLibraryVersion =
dependencies {
// TODO: extract a polaris-rest module as a thin layer for
// client to depends on.
implementation(project(":polaris-core")) {
exclude("org.apache.iceberg", "*")
exclude("com.azure", "*")
exclude("software.amazon.awssdk", "*")
exclude("com.google.cloud", "*")
exclude("io.airlift", "*")
exclude("io.smallrye", "*")
exclude("io.smallrye.common", "*")
exclude("io.swagger", "*")
exclude("org.apache.commons", "*")
}
implementation(project(":polaris-core")) { isTransitive = false }
Copy link
Contributor

@dimas-b dimas-b Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, the only thing the Spark Client uses from core is PolarisResourcePaths + PolarisEndpoints.

Depending on polaris-core without using any "core" functionality looks awkward to me. If the intention is to reuse those two classes, I believe it would be preferable to move them to an API module. WDYT (for followup)?

Copy link
Contributor Author

@gh-yzou gh-yzou Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is a TODO on top to put the class that can be shared between client and server into a different module, and the module can potentially be used by other clients that would like to talk to polaris


implementation(
"org.apache.iceberg:iceberg-spark-runtime-${sparkMajorVersion}_${scalaVersion}:${icebergVersion}"
Expand Down
Loading