Merged
Conversation
snazy
requested review from
RussellSpitzer,
ashvina,
jackye1995,
jbonofre and
vvcephei
as code owners
Member
Author
|
/cc @jbonofre since you're around ;) |
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
javadoc is still failing for me right now,
Looks like we still have a bunch of broken things
5 errors
100 warnings
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':polaris-core:javadoc'.
Did I miss something here?
Member
Author
|
Warnings - yea. This PR is meant to fix the actual errors. |
Member
5 - Errors, the compilation fails |
Member
Author
|
Argh - javadoc issues in generated OpenAPI code. Not much we can do about that, so excluding that error. |
Member
Author
|
Note: a CI step for that comes via #190 |
RussellSpitzer
approved these changes
Aug 28, 2024
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Looks good to me now, Javadoc building fine as well.
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Feb 11, 2026
* Fix PolarisEventListener javadoc (apache#3607) * Adjust javadoc to reference available methods. * Guides: add mandatory `curl` `--fail` option (apache#3610) `curl` does _not_ return an error code when the URL can be retrieved but returns an error HTTP status code, for example 404, 403, 401. This means that the health checks are yieldíng "OK" too early. This change adds the missing `--fail` option. * Guides: compose dependencies / long-option (apache#3611) Docker compose's "short" `depends_on` syntax (just mentioning the dependent service) does not assert on the expected condition (`service_healthy` or `service_completed_successfully`). This can lead to services being started too early, although their dependencies are not in the expected state. This change updates the affected parts to use the "long" syntax. * fix(deps): update dependency com.google.cloud:google-cloud-iamcredentials to v2.83.0 (apache#3635) * chore(deps): update registry.access.redhat.com/ubi9/openjdk-21-runtime docker tag to v1.24-2.1769595317 (apache#3631) * fix(deps): update dependency com.puppycrawl.tools:checkstyle to v13.1.0 (apache#3637) * chore(deps): update amazon/aws-cli docker tag to v2.33.12 (apache#3638) * fix(deps): update dependency com.azure:azure-sdk-bom to v1.3.4 (apache#3633) * fix(deps): update dependency ch.qos.logback:logback-classic to v1.5.27 (apache#3632) * chore(deps): update docker.io/openpolicyagent/opa docker tag to v1.13.1 (apache#3634) * CI: Fix site workflow concurrency (apache#3642) * Last merged commit 384be9e --------- Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com> Co-authored-by: Mend Renovate <bot@renovateapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.