Skip to content

Fix Production readiness for Persistence #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
singhpk234 merged 4 commits into from
May 30, 2025
Merged

Fix Production readiness for Persistence #1707

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c152cb2
Fix Production readiness for Eclipselink
singhpk234 May 28, 2025
aa8c2d7
Address review feedback
singhpk234 May 29, 2025
fd80dd2
Address review feedback
singhpk234 May 29, 2025
e6f675a
Update production readiness check
singhpk234 May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .../polaris/extension/persistence/impl/eclipselink/EclipseLinkProductionReadinessChecks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.nio.file.Path;
import org.apache.polaris.core.config.ProductionReadinessCheck;
import org.apache.polaris.core.config.ProductionReadinessCheck.Error;
import org.eclipse.microprofile.config.inject.ConfigProperty;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -36,7 +37,14 @@ public class EclipseLinkProductionReadinessChecks {
LoggerFactory.getLogger(EclipseLinkProductionReadinessChecks.class);

@Produces
public ProductionReadinessCheck checkJdbcUrl(EclipseLinkConfiguration eclipseLinkConfiguration) {
public ProductionReadinessCheck checkJdbcUrl(
Comment thread
singhpk234 marked this conversation as resolved.
Outdated
Comment thread
singhpk234 marked this conversation as resolved.
Outdated
EclipseLinkConfiguration eclipseLinkConfiguration,
@ConfigProperty(name = "polaris.persistence.type") String persistenceType) {
// This check should only be applicable when persistence uses EclipseLink.
if (!("eclipse-link".equalsIgnoreCase(persistenceType))) {
Comment thread
singhpk234 marked this conversation as resolved.
Outdated
Comment thread
singhpk234 marked this conversation as resolved.
Outdated
return ProductionReadinessCheck.OK;
}

try {
var confFile = eclipseLinkConfiguration.configurationFile().map(Path::toString).orElse(null);
var persistenceUnitName =
Expand Down