fix(metrics): Do not emit metrics for failed realm resolutions #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not a good practice to create metrics from error messages, so removing that.
adutra
requested review from
HonahX,
MonkeyCanCode,
RussellSpitzer,
ajantha-bhat,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Jun 13, 2025
* CI: Make helm-CI run for all changes (apache#1611) Whether helm-charts work (or not) doesn't only depend on what's on the `helm/` directory, but also the production code. It's hard to figure out which changes could break the helm-charts or what the helm-charts rely on. Therefore it's likely better to run Helm-CI for all changes. * fix(helm): Fix features configuration section & enhance docs (apache#1638) Fixes apache#1618 . Fixes apache#1634. This change adapts the `Values.features` section to the changes from apache#1572, also fixing incorrect configmap entries produced by the template. It also re-syncs the README.md file with README.md.gotmpl (the sync was lost a few commits ago), and enhances the instructions for running Helm tests locally. * Add DefaultConfigurationStoreDecorator to support inject callContext for DefaultConfigurationStore (apache#1505) * Set the default value of DROP WITH PURGE to false (apache#1619) * Core: Remove configure: INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST (apache#1624) * fix(metrics): Do not emit metrics for failed realm resolutions (apache#1642) * Add DISCLAIMER in Helm chart, fix LICENSE and NOTICE regarding code coming from Project Nessie in Helm chart (apache#1632) * main: Update dependency org.mockito:mockito-junit-jupiter to v5.18.0 (apache#1645) * main: Update dependency boto3 to v1.38.21 (apache#1644) * fix(CI): Resolve ambiguous `regtests` GH WF job name (apache#1636) Job names in GH WFs should be unique and not ambiguous to be able to distinguish those. * DREMIO: nit-fix * DREMIO: remove temporary workaround --------- Co-authored-by: Alexandre Dutra <[email protected]> Co-authored-by: gh-yzou <[email protected]> Co-authored-by: William Hyun <[email protected]> Co-authored-by: Yufei Gu <[email protected]> Co-authored-by: JB Onofré <[email protected]> Co-authored-by: Mend Renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not a good practice to create metrics from error messages. This change removes that.