-
Notifications
You must be signed in to change notification settings - Fork 348
Create a single binary distribution bundle #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d028731
[POLARIS] Add script to merge admin and server distributions
9726cf7
POLARIS-1: Fix repository configuration in custom plugins and restore…
60c3fb6
POLARIS-1: Remove run-script module - Remove run-script module from p…
5409eb7
delete module run script
5c4ab8c
delete unused file
3f0eddf
Add digest and fix the layout
a7a73fb
Remove unused build file
94624bb
Add signing
7280b9f
Fixed README and moduel name
6fbbad8
Change the distribution base name.
06cd4de
Add ASF license header to the new files
9e57ee8
Resolve comments
a80ac3a
Resolve the comments
00a6739
Use artifact dependency instead of cross-module task dependency
a029404
Remove the tarball and zip file build in admin and server module
62db142
Split run.sh to two commands server, admin.
be866e7
Split run.sh to two commands server, admin.
8744252
Update README.md
c62c61b
Add back DISCLAIMER
76df496
Resolve comments
f9451c8
Resolve comments
8d0b09d
Resolve comments
545d886
Support command line java options
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably preferable to do this excluding in the server and admin modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to exclude it in server and admin module. Didn't find a clean solution. It may not be worth it. Let me know if you got better solutioin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this is sub-optimal from the gradle build perspective, but I do not have a solution ATM, so I'm fine merging this change "as is" unless someone has a solution handy.