-
Notifications
You must be signed in to change notification settings - Fork 349
Added link to the Spark-Jupyter Notebook Getting Started from the main Getting Started Page #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eric-maynard
merged 4 commits into
apache:main
from
adnanhemani:ahemani/add_link_to_jupyter_quickstart
Apr 28, 2025
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviving a comment:
Also, this line looks kind of random more generally. This doesn't seem related to the above despite saying Additionally,.
Maybe we can break out a new header called like Beyond the Quickstart or Next Steps or whatever and put this (and other relevant links) there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context: I was talking to @flyrain offline and he had mentioned that he'd like us to provide a link to the Jupyter Notebook experience from the main Quickstart experience where users can explore further.
The issue with the Jupyter Notebook Getting Started is that it does not have the same amount of feature-richness as this main Getting Started page (no support for Postgres DB or Cloud Blob Storage) - so we're referring to it as an example of how to append to the current Docker Compose file.
I'm not opposed to putting a Next Steps header at the end, but today I think we will only have two links: 1) this and 2) Deploying Polaris in Production. Additionally, @flyrain would like to separate out Spark, Trino, and eventually Flink into their own pages. Do you think it's worth it to create that section at the end for two links? And I'm also slightly worried that if we do separate the engines into their own children pages, then where would this new "Next Steps" page go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is under the
Sample Commandsheader where it just doesn't really belong.I think it's fine if
Next Stepsis pretty thinThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, will add the section and revise this PR.