Merged
Conversation
Member
snazy
commented
Jul 30, 2024
snazy
commented
- configure-on-demand
- replace usages of deprecated Gradle APIs
build.gradle
Outdated
Member
There was a problem hiding this comment.
then shouldn't we just change the version? I'm confused why we would have this workaround?
Member
|
I really think we should break this one into separate PR's. The posfix -> . refactor I think is good but we are also doing a bunch of other things here. |
* configure-on-demand * replace usages of deprecated Gradle APIs
snazy
force-pushed
the
gradle-adoptions
branch
2 times, most recently
from
85bb9d1 to
2f4151b
Compare
Member
Author
That's all for the "replace deprecated Gradle API" part ( |
| } | ||
|
|
||
| project(":polaris-service") { | ||
| apply plugin: "application" |
Member
There was a problem hiding this comment.
For my own reference, Plugin specification is moved into project specific build files.
RussellSpitzer
approved these changes
Aug 5, 2024
eric-maynard
pushed a commit
to eric-maynard/polaris
that referenced
this pull request
Dec 12, 2024
…rop-table Add foreign table support for listTables and dropTable
eric-maynard
pushed a commit
to eric-maynard/polaris
that referenced
this pull request
Feb 15, 2025
Revert "Add testJar back"
snazy
added a commit
that referenced
this pull request
Jan 15, 2026
The "Spark Client Regression Tests" CI job requires some disk space to operate. With just a little bit of added "content", the job will fail to `no space left on device` during the `docker compose` invocation building an image. Such errors make it impossible to get the log from the workflow, unless you capture the log before the workflow runs into the `no space left on device` situation. With "no space left", GitHub workflow infra is unable to capture the logs. ``` #10 ERROR: failed to copy files: userspace copy failed: write /home/spark/polaris/v3.5/integration/build/2.13/quarkus-build/gen/quarkus-app/lib/main/com.google.http-client.google-http-client-1.47.1.jar: no space left on device ``` This change is a stop-gap solution to prevent this error from happening for now.
evindj
pushed a commit
to evindj/polaris
that referenced
this pull request
Jan 26, 2026
…#3429) The "Spark Client Regression Tests" CI job requires some disk space to operate. With just a little bit of added "content", the job will fail to `no space left on device` during the `docker compose` invocation building an image. Such errors make it impossible to get the log from the workflow, unless you capture the log before the workflow runs into the `no space left on device` situation. With "no space left", GitHub workflow infra is unable to capture the logs. ``` apache#10 ERROR: failed to copy files: userspace copy failed: write /home/spark/polaris/v3.5/integration/build/2.13/quarkus-build/gen/quarkus-app/lib/main/com.google.http-client.google-http-client-1.47.1.jar: no space left on device ``` This change is a stop-gap solution to prevent this error from happening for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.