Include exception when no server is found #14709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
approved these changes
Dec 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14709 +/- ##
============================================
+ Coverage 61.75% 64.03% +2.28%
- Complexity 207 1606 +1399
============================================
Files 2436 2706 +270
Lines 133233 149220 +15987
Branches 20636 22875 +2239
============================================
+ Hits 82274 95549 +13275
- Misses 44911 46664 +1753
- Partials 6048 7007 +959
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we found an issue when the log
No server found for requestwas printed. This log implies there is an exception that don't let us find servers to query, but the exception is not printed.This PR modifies the log to include a the first exception found. In case more than exception is affecting the system, we only log the first one, but we include the total number of exceptions in the log.