-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update javafmt #593
base: main
Are you sure you want to change the base?
Update javafmt #593
Conversation
Co-authored-by: He-Pin <[email protected]>
d9b3712
to
0ef541f
Compare
@He-Pin There seems to be some regression in the new version of javafmt, if you look at https://github.com/apache/incubator-pekko/actions/runs/5997908862/job/16265219790?pr=593 its failing to compile some java sources |
I tried it locally with sbt Test/compile:
|
If you run |
So I looked at diff for one of the problematic sources, i.e. |
I will take a try after work, wared. |
So I did a little digging, the core issue appear to be that the Java sources are not fed properly into the compiler i.e.
Now Now if I revert some of the changes that javafmt did on some of the source files, it does genuinely fix the issue. It appears that the import order is changing the semantics of the java source files. |
https://stackoverflow.com/questions/50145575/why-does-rearranging-imports-cause-compilation-to-fail might be related, in which case we should change the formatting style or add these files into ignore |
Updates and applies javafmt