Also check Scala 3 artifacts in MiMa #530
Conversation
|
part of #493 |
Thanks, added to resolves |
|
this doesn't resolve #493 because it doesn't enable a CI check |
Thanks, if this works I will update PR to add check to CI |
mdedetrich
force-pushed
the
also-check-scala3-in-mima
branch
from
fbc4a2d
to
9d80e1c
Compare
| @@ -16,7 +16,7 @@ addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.9.33") | |||
| // sbt-osgi 0.9.5 is available but breaks including jdk9-only classes | |||
| // sbt-osgi 0.9.6 is available but breaks populating pekko-protobuf-v3 | |||
| addSbtPlugin("com.typesafe.sbt" % "sbt-osgi" % "0.9.4") | |||
| addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.8.1") | |||
There was a problem hiding this comment.
This old version of sbt-mima is why it wasn't correctly resolving Scala 3 artifacts, this has since been resolved in latest MiMA
mdedetrich
force-pushed
the
also-check-scala3-in-mima
branch
from
9d80e1c
to
15377d3
Compare
| @@ -18,23 +18,18 @@ jobs: | |||
| if: github.repository == 'apache/incubator-pekko' | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
There was a problem hiding this comment.
matrix no longer needed, we test for all supported scala versions using sbt's +
| @@ -43,11 +38,11 @@ jobs: | |||
| run: cp .jvmopts-ci .jvmopts | |||
|
|
|||
| - name: Compile code | |||
| run: sbt "+~ ${{ matrix.scalaVersion }} Test/compile" | |||
There was a problem hiding this comment.
There is no reason to also compile Test scope, the point of this github check is to validate binary compatibility issues and this is never done against test code. There are other github workflows which check that the code generally compiles.
mdedetrich
force-pushed
the
also-check-scala3-in-mima
branch
from
15377d3
to
7cebede
Compare
While MiMa may not have worked on really early versions of Scala 3, its reported to be working fine with Scala 3.3 and I can also confirm this when adding MiMa to pekko-streams-circe (see mdedetrich/pekko-streams-circe#13)
Resolves: #493