Remove sonatype commands that shouldn't be run in release process #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
jrudolph,
gmethvin,
He-Pin,
nvollmar,
seglo and
pjfanning
He-Pin
reviewed
Jul 26, 2023
| @@ -18,6 +18,12 @@ ThisBuild / versionScheme := Some(VersionScheme.SemVerSpec) | |||
| sourceDistName := "apache-pekko" | |||
| sourceDistIncubating := true | |||
|
|
|||
| commands := commands.value.filterNot { command => | |||
| command.nameOption.exists { name => | |||
| name.contains("sonatypeRelease") || name.contains("sonatypeBundleRelease") | |||
There was a problem hiding this comment.
I would like to use StringUtil.containsAny(...) :)
There was a problem hiding this comment.
I don't think we can use that because this is an sbt build and hence the dependency that brings in StringUtil isn't available
There was a problem hiding this comment.
seems better to stick with plain Java/Scala
jrudolph
approved these changes
Jul 26, 2023
mdedetrich
deleted the
remove-sonatype-commands-which-shouldnt-be-executed
branch
This was referenced Jul 26, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in https://github.com/apache/incubator-pekko-site/wiki/Pekko-Release-Process#deploy-the-jars-to-apache-maven-repository-staging there are commands that shouldn't be executed. This PR removes these commands (which are brought in by sbt-sonatype) so release managers cannot accidentally execute them as part of release process.