Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use different article because spray.io is dead #542

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Apr 23, 2024

See #541

I'm not sure if https://www.baeldung.com/scala/magnet-pattern is ideal so if anyone has a better suggestion, pass it on.

This is a copy of the original blog.
https://web.archive.org/web/20240311111722/http://spray.io/blog/2012-12-13-the-magnet-pattern/

Would it make sense for us to copy this into the Pekko HTTP docs?

@sirthias would you have any objections if we did this?

@mdedetrich @raboof @jrudolph @kerr @nvollmar @Roiocam any thoughts?

@mdedetrich
Copy link
Contributor

Is there an issue with using the original spray link but via wayback machine? I believe this is standard practice for such style references?

@pjfanning
Copy link
Contributor Author

I can see that using the Wayback link is ok in the short term but it does lead to users being asked for donations, etc.

@mdedetrich
Copy link
Contributor

I can see that using the Wayback link is ok in the short term but it does lead to users being asked for donations, etc.

Seems like the least worst option to me, especially since the whole point of Wayback machine is to archive this content forever?

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin
Copy link
Member

He-Pin commented Apr 24, 2024

As the spray is there, I think this is fine, user would like to see the content, not the url

@laglangyue
Copy link
Contributor

LGTM

@sirthias
Copy link
Contributor

sirthias commented Apr 24, 2024

I'm sorry that spray.io is dead now, but I was personally sitting on the domain and hosting cost for >10 years before eventually getting an offer for the domain from a nice someone from Korea who would like to use it for another not-for-profit project.
So I sold and transferred it two days ago.

Part of the deal is the keep the old artifact repo at http://repo.spray.io (which still sees a decent amount of traffic!) intact for some time longer, so that's not a problem.

The only thing of some value on the actual spray.io site was probably the post on the magnet pattern (from 2012!).
I'm completely fine with linking to the archive version of it, if that works for pekko.

An alternative could be to directly implant it into the pekko docs. The source is still around and written in reStructuredText (my preferred format at the time), which shouldn't be too hard to transcribe to Markdown or similar.

@pjfanning
Copy link
Contributor Author

Thanks @sirthias for the quick and detailed response.

GitHub does a pretty decent job of rendering the .rst file too - so linking to that may be an option.

https://github.com/spray/spray/blob/master/docs/blog/2012-12-13-the-magnet-pattern.rst

I'm happy enough to use Wayback Machine link as this PR now does.

@pjfanning pjfanning merged commit f998dde into apache:main Apr 25, 2024
10 checks passed
@pjfanning pjfanning deleted the spray-doc branch April 25, 2024 09:24
pjfanning added a commit to pjfanning/incubator-pekko-http that referenced this pull request Apr 25, 2024
* use different article because spray.io is dead

* use wayback instead
pjfanning added a commit that referenced this pull request Apr 25, 2024
* use different article because spray.io is dead

* use wayback instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants