Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to remove some uses of ActorMaterializer #347

Merged
merged 5 commits into from
Oct 30, 2023
Merged

try to remove some uses of ActorMaterializer #347

merged 5 commits into from
Oct 30, 2023

Conversation

pjfanning
Copy link
Contributor

class is deprecated

@pjfanning pjfanning added this to the 1.1.0 milestone Oct 29, 2023
@pjfanning pjfanning marked this pull request as draft October 29, 2023 23:01
jrudolph
jrudolph approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM

@pjfanning pjfanning marked this pull request as ready for review October 30, 2023 09:36
@pjfanning pjfanning merged commit 87f55da into apache:main Oct 30, 2023
9 of 10 checks passed
@pjfanning pjfanning deleted the actor-materializer branch October 30, 2023 09:36
@pjfanning pjfanning mentioned this pull request Oct 30, 2023
Merged
He-Pin pushed a commit to He-Pin/incubator-pekko-http that referenced this pull request Dec 24, 2023
@pjfanning @He-Pin
try to remove some uses of ActorMaterializer (apache#347)
5d6ca66 
* try to remove some uses of ActorMaterializer

* compile issue

* try to fix tests

* more changes

* Update PekkoHttp1020MigrationSpec.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @jrudolph