Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set determineLatestSnapshot to properly resolve latest release #271

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Set determineLatestSnapshot to properly resolve latest release #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/PekkoDependency.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ object PekkoDependency {
val default = pekkoDependency(defaultVersion = minimumExpectedPekkoVersion)
def docs = default

lazy val mainSnapshot = Artifact(determineLatestSnapshot("0.0.0"), true)
Copy link
Contributor Author

@mdedetrich mdedetrich Jul 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed to determineLatestSnapshot("0.0.0") because for a long period of time Pekko core had no release which caused determineLatestSnapshot() to fail. Using determineLatestSnapshot("0.0.0") means that it will resolve snapshots from 0.0.0 which is now outdated.

Its meant to be determineLatestSnapshot() which means it will use the prefix for the latest released version (now 1.0.1)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you rebase? #270 has been merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AhI see, let me rebase and also change commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjfanning Done, I have also updated the commit message to properly reflect whats going on.

lazy val mainSnapshot = Artifact(determineLatestSnapshot(), true)

val pekkoVersion: String = default match {
case Artifact(version, _) => version
Expand Down
Loading