Remove Base64Parsing #259
Merged
Remove Base64Parsing #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
Jul 23, 2023
•
pjfanning
commented
- use parboiled class instead (we have removed all the other parboiled code, now that we have a jar dependency for it)
- the code that I moved to Http2SettingsHeader did not come from the parboiled Base64Parsing class
- relates to add parboiled2 license #257
He-Pin
reviewed
Jul 23, 2023
| @@ -42,4 +48,5 @@ private[pekko] object Http2SettingsHeader { | |||
| val reader = new io.ByteStringParser.ByteReader(bytes) | |||
| Http2FrameParsing.readSettings(reader, log) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Does the removed method been used anywhere ,eg in grpc module?
There was a problem hiding this comment.
the code that is being removed is package private code so it would be really bad practice to use it outside of this module
There was a problem hiding this comment.
I've just checked incubator-pekko-grpc, incubator-pekko-connectors and incububator-pekko-management git repos and can't find any uses of the class that I am removing in this PR.
There was a problem hiding this comment.
I've committed a change that removes the new line
pjfanning
commented
Jul 23, 2023
| Copyright © 2009-2013 Mathias Doenitz <http://parboiled2.org> | ||
| Copyright © 2013 Alexander Myltsev | ||
|
|
||
| --------------- |
There was a problem hiding this comment.
only added yesterday - but not needed if we remove Base64Parsing.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.