Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: also aggregate httpScalafix, so headerCheck will also work on those files #245

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

build: also aggregate httpScalafix, so headerCheck will also work on those files #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
611c1ce
build: also aggregate httpScalafix, so headerCheck will also work on …
jrudolph Jul 19, 2023
f70f81c
scalafix: fix RuleSuite to use latest scalatest syntax
jrudolph Jul 19, 2023
385220d
fix rule placement for scalafix test
jrudolph Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ lazy val aggregatedProjects: Seq[ProjectReference] = userProjects ++ List[Projec
docs,
// compatibilityTests,
httpJmhBench,
billOfMaterials)
billOfMaterials,
httpScalafix)
lazy val root = Project(
id = "pekko-http",
base = file("."))
Expand Down
8 changes: 4 additions & 4 deletions ...afix-test-input/src/main/scala/org/apache/pekko/http/fix/MigrateToServerBuilderTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/*
rule = MigrateToServerBuilder # This has to be at the top
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with running the scalafix test was that the license header must not be above the rule header.

*/

/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* license agreements; and to You under the Apache License, version 2.0:
Expand All @@ -7,10 +11,6 @@
* This file is part of the Apache Pekko project, which was derived from Akka.
*/

/*
rule = MigrateToServerBuilder
*/

package org.apache.pekko.http.fix

import org.apache.pekko
Expand Down Expand Up @@ -75,9 +75,9 @@
Http() // needed to appease formatter
// format: ON

http.bindAndHandle(route, "127.0.0.1", port = 8080)

Check failure on line 78 in http-scalafix/scalafix-test-input/src/main/scala/org/apache/pekko/http/fix/MigrateToServerBuilderTest.scala

View workflow job for this annotation

GitHub Actions / Compile and test (3.3, 8) 

value bindAndHandle is not a member of org.apache.pekko.http.scaladsl.HttpExt

Check failure on line 78 in http-scalafix/scalafix-test-input/src/main/scala/org/apache/pekko/http/fix/MigrateToServerBuilderTest.scala

View workflow job for this annotation

GitHub Actions / Compile and test (3.3, 8) 

not found: value port

Check failure on line 78 in http-scalafix/scalafix-test-input/src/main/scala/org/apache/pekko/http/fix/MigrateToServerBuilderTest.scala

View workflow job for this annotation

GitHub Actions / Compile and test (3.3, 11) 

value bindAndHandle is not a member of org.apache.pekko.http.scaladsl.HttpExt

Check failure on line 78 in http-scalafix/scalafix-test-input/src/main/scala/org/apache/pekko/http/fix/MigrateToServerBuilderTest.scala

View workflow job for this annotation

GitHub Actions / Compile and test (3.3, 11) 

not found: value port
http.bindAndHandleAsync(handler, "127.0.0.1", 8080)

Check failure on line 79 in http-scalafix/scalafix-test-input/src/main/scala/org/apache/pekko/http/fix/MigrateToServerBuilderTest.scala

View workflow job for this annotation

GitHub Actions / Compile and test (3.3, 8) 

value bindAndHandleAsync is not a member of org.apache.pekko.http.scaladsl.HttpExt

Check failure on line 79 in http-scalafix/scalafix-test-input/src/main/scala/org/apache/pekko/http/fix/MigrateToServerBuilderTest.scala

View workflow job for this annotation

GitHub Actions / Compile and test (3.3, 11) 

value bindAndHandleAsync is not a member of org.apache.pekko.http.scaladsl.HttpExt
http.bindAndHandleSync(syncHandler, "127.0.0.1", 8080)

Check failure on line 80 in http-scalafix/scalafix-test-input/src/main/scala/org/apache/pekko/http/fix/MigrateToServerBuilderTest.scala

View workflow job for this annotation

GitHub Actions / Compile and test (3.3, 8) 

value bindAndHandleSync is not a member of org.apache.pekko.http.scaladsl.HttpExt

Check failure on line 80 in http-scalafix/scalafix-test-input/src/main/scala/org/apache/pekko/http/fix/MigrateToServerBuilderTest.scala

View workflow job for this annotation

GitHub Actions / Compile and test (3.3, 11) 

value bindAndHandleSync is not a member of org.apache.pekko.http.scaladsl.HttpExt

Http(actorSystem).bindAndHandle(route, "127.0.0.1", port = 8080)
Http(actorSystem).bindAndHandleAsync(handler, "127.0.0.1", 8080)
Expand Down
4 changes: 2 additions & 2 deletions http-scalafix/scalafix-tests/src/test/scala/org/apache/pekko/http/fix/RuleSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

package org.apache.pekko.http.fix

import org.scalatest.FunSpecLike
import org.scalatest.funspec.AnyFunSpecLike
import scalafix.testkit.AbstractSemanticRuleSuite

class RuleSuite extends AbstractSemanticRuleSuite with FunSpecLike {
class RuleSuite extends AbstractSemanticRuleSuite with AnyFunSpecLike {
runAllTests()
}
Loading