PARQUET-2155: Upgrade protobuf version to 3.17.3#973
Merged
ggershinsky merged 3 commits intoapache:masterfrom Jul 19, 2022
Merged
PARQUET-2155: Upgrade protobuf version to 3.17.3#973ggershinsky merged 3 commits intoapache:masterfrom
ggershinsky merged 3 commits intoapache:masterfrom
Conversation
4 tasks
Contributor
|
this is a different solution to mine, which just changed the protoc artifact. i think my one is lower risk, but this one can address other protobuf issues |
Contributor
|
...but the #970 patch should add a comment saying "not needed once protobuf is incremented to 3.20+" |
Member
Author
|
To reduce the risk, we can also change 3.20.1 to 3.17.1 which seems to be the lowest version that has the aarch_64 artifact. |
Member
Author
Contributor
|
Yeah, we can do 3.20.1 later. |
Member
Author
|
updated |
Member
Author
|
gently ping @shangxinli @ggershinsky |
Contributor
|
sure. if no other input by the end of this week, I'll merge it then. |
Contributor
|
LGTM |
Contributor
|
now this is merged in, should the jira be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the repo can't be compiled with M1 Mac:
since the artifact for M1 arch was not published: https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.16.1/
This upgrade the protobuf version to 3.17.3 to support compiling on M1 Mac:
https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.17.3/ (with osx_aarch_64 artifact)
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation