Skip to content

[PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase. #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gszadovszky merged 1 commit into from
Aug 16, 2021
Merged

[PARQUET-2073] Fix estimate remaining row count in ColumnWriteStoreBase. #922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriteStoreBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,11 @@ private void sizeCheck() {
} else {
rowCountForNextRowCountCheck = min(rowCountForNextRowCountCheck, writer.getRowsWrittenSoFar() + pageRowCountLimit);
}
//estimate remaining row count by previous input for next row count check
long rowsToFillPage =
usedMem == 0 ?
props.getMaxRowCountForPageSizeCheck()
: (long) rows / usedMem * remainingMem;
: rows * remainingMem / usedMem;
Copy link
Contributor

@shangxinli shangxinli Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we worry about overflow by (rows * remainingMem)?

Copy link
Contributor

@gszadovszky gszadovszky Aug 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've felt it as a low risk. We are talking about pages here so neither the row count nor the used memory should be too high that this would overflow.

Copy link
Member Author

@Ted-Jiang Ted-Jiang Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as gszadovszky +1

if (rowsToFillPage < minRecordToWait) {
minRecordToWait = rowsToFillPage;
}
Expand Down