Skip to content

PARQUET-2025: Update Snappy version to 1.1.8.3 #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fokko merged 1 commit into from
Apr 19, 2021
Merged

PARQUET-2025: Update Snappy version to 1.1.8.3 #893

Fokko merged 1 commit into from
Apr 19, 2021

Conversation

@williamhyun
Copy link
Member

@williamhyun williamhyun commented Apr 14, 2021 •
edited by Fokko
Loading

This PR aims to update Snappy to 1.1.8.3 to support Mac m1.

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    This is a dependency update. All existing tests should pass.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@cyraid
Copy link

cyraid commented Apr 15, 2021

May I ask why there are so many open pull requests from years ago? Is this repository dead?

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Apr 17, 2021

cc @Fokko

gszadovszky
gszadovszky approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@gszadovszky gszadovszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @williamhyun for taking care of this. However, I am not sure if it worth the effort to do minor/patch level upgrades of our dependencies far from a release. I think, it is better to do such upgrades to the latest available releases just before a release. (I am not against this just mentioning.)

@cyraid, if the repo would be dead we would not start and accept new PRs to it. I guess the old open PRs you are talking about are more or less abandoned because no one had the time to review/close them. Feel free to contribute and comment to these PRs if you think they worth a re-check or we should close them. Also, this topic is not related to this particular PR so please do not comment here. Feel free to open a discussion about this topic on the dev mailing list.

@Fokko Fokko merged commit 095c78f into apache:master Apr 19, 2021
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Apr 19, 2021

Thank you, @williamhyun and all.

This will unblock Apache Parquet snappy development in Apple Silicon environment!

elikkatz added a commit to TheWeatherCompany/parquet-mr that referenced this pull request Jun 2, 2021
@elikkatz
Merge branch 'master' of https://github.com/apache/parquet-mr
90c012e 
* 'master' of https://github.com/apache/parquet-mr: (222 commits)
  PARQUET-2052: Integer overflow when writing huge binary using dictionary encoding (apache#910)
  PARQUET-2041: Add zstd to `parquet.compression` description of ParquetOutputFormat Javadoc (apache#899)
  PARQUET-2050: Expose repetition & definition level from ColumnIO (apache#908)
  PARQUET-1761: Lower Logging Level in ParquetOutputFormat (apache#745)
  PARQUET-2046: Upgrade Apache POM to 23 (apache#904)
  PARQUET-2048: Deprecate BaseRecordReader (apache#906)
  PARQUET-1922: Deprecate IOExceptionUtils (apache#825)
  PARQUET-2037: Write INT96 with parquet-avro (apache#901)
  PARQUET-2044: Enable ZSTD buffer pool by default (apache#903)
  PARQUET-2038: Upgrade Jackson version used in parquet encryption. (apache#898)
  Revert "[WIP] Refactor GroupReadSupport to unuse deprecated api (apache#894)"
  PARQUET-2027: Fix calculating directory offset for merge (apache#896)
  [WIP] Refactor GroupReadSupport to unuse deprecated api (apache#894)
  PARQUET-2030: Expose page size row check configurations to ParquetWriter.Builder (apache#895)
  PARQUET-2031: Upgrade to parquet-format 2.9.0 (apache#897)
  PARQUET-1448: Review of ParquetFileReader (apache#892)
  PARQUET-2020: Remove deprecated modules (apache#888)
  PARQUET-2025: Update Snappy version to 1.1.8.3 (apache#893)
  PARQUET-2022: ZstdDecompressorStream should close `zstdInputStream` (apache#889)
  PARQUET-1982: Random access to row groups in ParquetFileReader (apache#871)
  ...

# Conflicts:
#	parquet-column/src/main/java/org/apache/parquet/example/data/simple/SimpleGroup.java
#	parquet-hadoop/pom.xml
#	parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
#	parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
sunchao pushed a commit to sunchao/parquet-mr that referenced this pull request Jun 16, 2022
@williamhyun @kazuyukitanimura
PARQUET-2025: Update Snappy version to 1.1.8.3 (apache#893)
88cddea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

@gszadovszky gszadovszky gszadovszky approved these changes

+2 more reviewers

@chenjunjiedada chenjunjiedada chenjunjiedada approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@williamhyun @cyraid @dongjoon-hyun @Fokko @chenjunjiedada @gszadovszky