Revert "PARQUET-1381: Add merge blocks command to parquet-tools (#512)" #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivanfi
approved these changes
Feb 21, 2019
Contributor
|
@kgalieva Unfortunately, as Gabor described above, the block-merging functionality seems to be incompatible with the internal logic of the API in its current form. I am sorry to see your contribution about to be reverted and would like to emphasize that your efforts have really been appreciated. If a way is found to resolve this conceptional misalignment, we would be happy to include this functionality in the future in an updated form. |
shangxinli
added a commit
to shangxinli/parquet-mr
that referenced
this pull request
Mar 1, 2023
Summary: Merge two commits from upstream Revert "PARQUET-1381: Add merge blocks command to parquet-tools (apache#512) apache#621 PARQUET-1533: TestSnappy() throws OOM exception with Parquet-1485 change apache#622 Reviewers: pavi, leisun Reviewed By: leisun Differential Revision: https://code.uberinternal.com/D2544359
shangxinli
pushed a commit
to shangxinli/parquet-mr
that referenced
this pull request
Mar 1, 2023
Summary: Revert "PARQUET-1381: Add merge blocks command to parquet-tools (apache#512)" (apache#621) This reverts commit 863a081. The design of this feature has conceptional problems and also works incorrectly. See PARQUET-1381 for more details. PARQUET-1531: Page row count limit causes empty pages to be written from MessageColumnIO (apache#620) PARQUET-1544: Possible over-shading of modules (apache#628) Reviewers: pavi Reviewed By: pavi Differential Revision: https://code.uberinternal.com/D2769319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 863a081.
The design of this feature has conceptional problems and also works incorrectly. See PARQUET-1381 for more details.