PARQUET-1391: Integrate Bloom filter logic #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszadovszky
requested changes
Mar 8, 2019
Contributor
gszadovszky
left a comment
gszadovszky
left a comment
There was a problem hiding this comment.
Sorry for the late response. Please, find my comments below.
...et-column/src/main/java/org/apache/parquet/column/values/bloomfilter/BloomFilterUtility.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/main/java/org/apache/parquet/filter2/BloomFilterLevel/BloomFilterImpl.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/main/java/org/apache/parquet/filter2/BloomFilterLevel/BloomFilterImpl.java
Outdated
Show resolved
Hide resolved
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/BloomFilterDataReader.java
Outdated
Show resolved
Hide resolved
gszadovszky
requested changes
Mar 12, 2019
parquet-hadoop/src/main/java/org/apache/parquet/filter2/BloomFilterLevel/BloomFilterImpl.java
Outdated
Show resolved
Hide resolved
...column/src/main/java/org/apache/parquet/column/values/bloomfilter/BlockSplitBloomFilter.java
Show resolved
Hide resolved
gszadovszky
approved these changes
Mar 18, 2019
chenjunjiedada
added a commit
to chenjunjiedada/parquet-mr
that referenced
this pull request
Jan 7, 2020
gszadovszky
pushed a commit
that referenced
this pull request
Feb 26, 2020
shangxinli
pushed a commit
to shangxinli/parquet-mr
that referenced
this pull request
Mar 1, 2020
* PARQUET-1328: Add Bloom filter reader and writer (apache#587) * PARQUET-1516: Store Bloom filters near to footer (apache#608) * PARQUET-1391: Integrate Bloom filter logic (apache#619) * PARQUET-1660: align Bloom filter implementation with format (apache#686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.