PARQUET-84: Avoid reading rowgroup metadata in memory on the client side. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static final MetadataFilter NO_FILTER = new NoFilter(); | ||
| public static final MetadataFilter SKIP_ROW_GROUPS = new SkipMetadataFilter(); | ||
| /** | ||
| * [ startOffset, endOffset ( |
There was a problem hiding this comment.
fix comment: [ startOffset, endOffset )
julienledem
changed the title
julienledem
force-pushed
the
skip_reading_row_groups
branch
from
7957a92 to
5b6bd1b
Compare
| } | ||
| } | ||
| /** | ||
| * [ startOffset, endOffset ( |
|
LGTM! |
|
@tsdeng and the build is green! |
tongjiechen
pushed a commit
to tongjiechen/incubator-parquet-mr
that referenced
this pull request
Oct 8, 2014
…ide. This will improve reading big datasets with a large schema (thousands of columns) Instead rowgroup metadata can be read in the tasks where each tasks reads only the metadata of the file it's reading Author: julien <[email protected]> Closes apache#45 from julienledem/skip_reading_row_groups and squashes the following commits: ccdd08c [julien] fix parquet-hive 24a2050 [julien] Merge branch 'master' into skip_reading_row_groups 3d7e35a [julien] adress review feedback 5b6bd1b [julien] more tests 323d254 [julien] sdd unit tests f599259 [julien] review feedback fb11f02 [julien] fix backward compatibility check 2c20b46 [julien] cleanup readFooters methods 3da37d8 [julien] fix read summary ab95a45 [julien] cleanup 4d16df3 [julien] implement task side metadata 9bb8059 [julien] first stab at integrating skipping row groups
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Feb 6, 2015
…ide. This will improve reading big datasets with a large schema (thousands of columns) Instead rowgroup metadata can be read in the tasks where each tasks reads only the metadata of the file it's reading Author: julien <[email protected]> Closes apache#45 from julienledem/skip_reading_row_groups and squashes the following commits: ccdd08c [julien] fix parquet-hive 24a2050 [julien] Merge branch 'master' into skip_reading_row_groups 3d7e35a [julien] adress review feedback 5b6bd1b [julien] more tests 323d254 [julien] sdd unit tests f599259 [julien] review feedback fb11f02 [julien] fix backward compatibility check 2c20b46 [julien] cleanup readFooters methods 3da37d8 [julien] fix read summary ab95a45 [julien] cleanup 4d16df3 [julien] implement task side metadata 9bb8059 [julien] first stab at integrating skipping row groups Conflicts: parquet-hadoop/src/main/java/parquet/hadoop/ParquetFileWriter.java parquet-hadoop/src/main/java/parquet/hadoop/ParquetInputFormat.java parquet-hadoop/src/test/java/parquet/hadoop/example/TestInputOutputFormat.java Resolution: Conflicts were from whitespace changes and strict type checking (not backported). Removed dependence on strict type checking.
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Mar 9, 2015
…ide. This will improve reading big datasets with a large schema (thousands of columns) Instead rowgroup metadata can be read in the tasks where each tasks reads only the metadata of the file it's reading Author: julien <[email protected]> Closes apache#45 from julienledem/skip_reading_row_groups and squashes the following commits: ccdd08c [julien] fix parquet-hive 24a2050 [julien] Merge branch 'master' into skip_reading_row_groups 3d7e35a [julien] adress review feedback 5b6bd1b [julien] more tests 323d254 [julien] sdd unit tests f599259 [julien] review feedback fb11f02 [julien] fix backward compatibility check 2c20b46 [julien] cleanup readFooters methods 3da37d8 [julien] fix read summary ab95a45 [julien] cleanup 4d16df3 [julien] implement task side metadata 9bb8059 [julien] first stab at integrating skipping row groups Conflicts: parquet-hadoop/src/main/java/parquet/hadoop/ParquetFileWriter.java parquet-hadoop/src/main/java/parquet/hadoop/ParquetInputFormat.java parquet-hadoop/src/test/java/parquet/hadoop/example/TestInputOutputFormat.java Resolution: Conflicts were from whitespace changes and strict type checking (not backported). Removed dependence on strict type checking.
sunchao
added a commit
to sunchao/parquet-mr
that referenced
this pull request
Aug 1, 2022
apache#43 added the logic to return null when `compressedPages` become empty. However this is not correct with async IO enabled, since the first page may not have been read yet, when the method is called. This fixes it by adding a `isFinished` variable to indicate whether all the pages have been consumed in the `ColumnChunkPageReadStore`. In addition, this also added a few pre-condition checks to make sure the object won't run into some invalid state.
sunchao
added a commit
to sunchao/parquet-mr
that referenced
this pull request
Sep 16, 2022
Follow-up of apache#45. This fixes the pre-condition check of `getPageValueCount` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve reading big datasets with a large schema (thousands of columns)
Instead rowgroup metadata can be read in the tasks where each tasks reads only the metadata of the file it's reading