PARQUET-1128: [Java] Upgrade the Apache Arrow version to 0.8.0 for SchemaConverter #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hemaConverter Upgrade Apache Arrow version to 0.8.0. Author: Masayuki Takahashi <[email protected]>
julienledem
reviewed
Jan 9, 2018
| case TIMESTAMP_MILLIS: | ||
| return field(new ArrowType.Timestamp(org.apache.arrow.vector.types.TimeUnit.MILLISECOND, "UTC")); | ||
| case TIME_MILLIS: | ||
| return field(new ArrowType.Date(DateUnit.MILLISECOND)); |
There was a problem hiding this comment.
@julienledem I made a mistake. I will fix it. Thanks.
|
Thanks for you contribution. see my question above. |
…hemaConverter Fix the wrong conversion from TIME_MILLIS(Parquet) to Time(Arrow). Author: Masayuki Takahashi <[email protected]>
masayuki038
commented
Jan 13, 2018
| @@ -471,6 +469,7 @@ public TypeMapping convertINT64(PrimitiveTypeName primitiveTypeName) throws Runt | |||
| case LIST: | |||
| case MAP: | |||
| case MAP_KEY_VALUE: | |||
| case TIME_MILLIS: | |||
| throw new IllegalArgumentException("illegal type " + type); | |||
| } | |||
There was a problem hiding this comment.
@julienledem @xhochy And I changed above in SchemaConverter#convertINT64 because TIME_MILLIS only takes int32.
There was a problem hiding this comment.
@julienledem @xhochy Could you please check this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I converted parquet(1.9.1-SNAPSHOT) schema to arrow(0.4.0) with SchemaConverter, this exception raised.
This reason is that SchemaConverter refer to Apache Arrow 0.1.0.
I upgrade the Apache Arrow version to 0.8.0(latest) for SchemaConverter.