PARQUET-669: allow reading footers from provided file listing and streams #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
force-pushed
the
robertk/allow-reading-footers-from-streams
branch
from
c93a22d to
b64c890
Compare
robert3005
changed the title
robert3005
force-pushed
the
robertk/allow-reading-footers-from-streams
branch
from
b64c890 to
22bc0fa
Compare
robert3005
changed the title
| * @return the metadata blocks in the footer | ||
| * @throws IOException if an error occurs while reading the file | ||
| */ | ||
| public static final ParquetMetadata readFooter(FileStatus file, FSDataInputStream f, MetadataFilter filter) throws IOException { |
Member
There was a problem hiding this comment.
We only need need the file size here not the full FileStatus object.
(since we're making this public)
robert3005
force-pushed
the
robertk/allow-reading-footers-from-streams
branch
from
22bc0fa to
4d8a54c
Compare
Member
|
LGTM |
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
…eams The use case is that I want to reuse existing listing of files and avoid doing it again when opening streams. This is in case where filesystem.open is expensive but you have other means of obtaining input stream for a file. Author: Robert Kruszewski <[email protected]> Closes apache#357 from robert3005/robertk/allow-reading-footers-from-streams and squashes the following commits: 4d8a54c [Robert Kruszewski] allow reading footers from provided file listing and streams
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 10, 2017
…eams The use case is that I want to reuse existing listing of files and avoid doing it again when opening streams. This is in case where filesystem.open is expensive but you have other means of obtaining input stream for a file. Author: Robert Kruszewski <[email protected]> Closes apache#357 from robert3005/robertk/allow-reading-footers-from-streams and squashes the following commits: 4d8a54c [Robert Kruszewski] allow reading footers from provided file listing and streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case is that I want to reuse existing listing of files and avoid doing it again when opening streams. This is in case where filesystem.open is expensive but you have other means of obtaining input stream for a file.