Skip to content

GH-3207: ParquetFileReader supports detachFileInputStream #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 2 commits into from
May 7, 2025
Merged

GH-3207: ParquetFileReader supports detachFileInputStream #3208

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24e9373
GH-3207: ParquetFileReader should allow closing resources except for …
pan3793 Apr 30, 2025
186cd67
detachFileInputStream
pan3793 May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,8 +1743,12 @@ public OffsetIndex readOffsetIndex(ColumnChunkMetaData column) throws IOExceptio

@Override
public void close() throws IOException {
close(true);
}

public void close(boolean closeFileInputStream) throws IOException {
Copy link
Copy Markdown
Member

@wgtmac wgtmac May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to explicitly add a detachFileInputStream method to set f to null so we don't need to hack the close here?

cc @gszadovszky

Copy link
Copy Markdown
Member Author

@pan3793 pan3793 May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your suggestion, but are you comfortable removing the final modifier for f?

protected final SeekableInputStream f;

Copy link
Copy Markdown
Contributor

@gszadovszky gszadovszky May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Member Author

@pan3793 pan3793 May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Copy Markdown
Member

@wgtmac wgtmac May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! It would be good to reflect the change in the PR title.

Copy link
Copy Markdown
Member Author

@pan3793 pan3793 May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title is updated too

Copy link
Copy Markdown
Member

@wgtmac wgtmac May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged. Thanks @pan3793 and @gszadovszky!

try {
if (f != null) {
if (closeFileInputStream && f != null) {
f.close();
}
} finally {
Expand Down