GH-3114: Fix LogicalType conversions for nested records on Avro <= 1.8 #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @RustedBones can you take a look when you have a chance? |
|
Thanks for the fix! Could you please create a Github issue for this and associate with it in the title? cc @Fokko @gszadovszky as Avro experts. |
RustedBones
reviewed
Jan 6, 2025
parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java
Outdated
Show resolved
Hide resolved
clairemcginty
changed the title
RustedBones
approved these changes
Jan 6, 2025
Fokko
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
This makes sense to me @clairemcginty, thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes logical type conversions for nested records on Avro <= 1.8. This was also addressed in https://github.com/apache/parquet-java/pull/1296/files but was missing the test case where all logical types are in nested classes and there are zero top-level logical types. In this case, invoking
clazz.getDeclaredField("conversions")in AvroRecordConverter throws aNoSuchFieldExceptionand terminates the loop before attempting to traverse the record's inner fields.Fixes #3114
What changes are included in this PR?
Fixes built-in logical type conversions for Avro records that contain only nested logical type fields on <= 1.8
Are these changes tested?
Included a test for the case described above
Are there any user-facing changes?