PARQUET-2237 Improve performance by skipping BloomFilter when column has a dictionary filter #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabola
changed the title
…s already a dictionary filter
Contributor
Author
|
@wgtmac @gszadovszky If you have time, please take a look, thank you |
…s already a dictionary filter
Contributor
Author
|
The implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
StatisticsFilter(minMax) ,DictionaryFilter,BloomFilterImplare used one by one to filter RowGroups. But when column has a dictionary filter and all pages are encoded, there is no needed to useBloomFilterImpl.Why are the changes needed?
Improve performance when filter RowGroups.
In the old parquet v1 , BloomFilter is still generated, even if the column pages are all encoded by dictionary(fix this bug in #1033)
Some more discussions can be seen here #1023 (comment)