Implement review

apache · Aug 27, 2017 · d694f20 · d694f20
1 parent c389d6b
commit d694f20
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java b/parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java
@@ -99,7 +99,7 @@ private <T> Builder<? extends Builder<?, GroupBuilder<T>>, GroupBuilder<T>> addR
     return builder
         .group(Type.Repetition.REQUIRED).as(OriginalType.LIST)
           .group(Type.Repetition.REPEATED)
-            .primitive(primitiveType, Type.Repetition.OPTIONAL).as(originalType)
+            .primitive(primitiveType, Type.Repetition.REQUIRED).as(originalType)
           .named("element")
         .named("list");
   }

diff --git a/parquet-protobuf/src/test/java/org/apache/parquet/proto/ProtoSchemaConverterTest.java b/parquet-protobuf/src/test/java/org/apache/parquet/proto/ProtoSchemaConverterTest.java
@@ -124,7 +124,7 @@ public void testConvertRepetition() throws Exception {
         "  required int32 requiredPrimitive = 2;\n" +
         "  required group repeatedPrimitive (LIST) = 3 {\n" +
         "    repeated group list {\n" +
-        "      optional int32 element;\n" +
+        "      required int32 element;\n" +
         "    }\n" +
         "  }\n" +
         "  optional group optionalMessage = 7 {\n" +
@@ -150,7 +150,7 @@ public void testProto3ConvertRepetition() throws Exception {
         "  optional int32 optionalPrimitive = 1;\n" +
         "  required group repeatedPrimitive (LIST) = 3 {\n" +
         "    repeated group list {\n" +
-        "      optional int32 element;\n" +
+        "      required int32 element;\n" +
         "    }\n" +
         "  }\n" +
         "  optional group optionalMessage = 7 {\n" +