Log values writer factory chosen

apache · May 17, 2016 · 1fa93b1 · 1fa93b1
1 parent ad511be
commit 1fa93b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java b/parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java
@@ -181,6 +181,10 @@ public int getMaxRowCountForPageSizeCheck() {
     return maxRowCountForPageSizeCheck;
   }
 
+  public ValuesWriterFactory getValuesWriterFactory() {
+    return valuesWriterFactory;
+  }
+
   public boolean estimateNextSizeCheck() {
     return estimateNextSizeCheck;
   }

diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java
@@ -335,6 +335,7 @@ public static ValuesWriterFactory getValuesWriterFactory(Configuration conf) {
     Class<? extends ValuesWriterFactory> factoryOverride =
       (Class<? extends ValuesWriterFactory>) ConfigurationUtil.getClassFromConfig(conf, WRITER_FACTORY_OVERRIDE, ValuesWriterFactory.class);
     if (factoryOverride == null) {
+      // no override specified, fall back to default
       factoryOverride = ParquetProperties.DEFAULT_VALUES_WRITER_FACTORY;
     }
 
@@ -413,6 +414,7 @@ public RecordWriter<Void, T> getRecordWriter(Configuration conf, Path file, Comp
       LOG.info("Page size checking is: " + (props.estimateNextSizeCheck() ? "estimated" : "constant"));
       LOG.info("Min row count for page size check is: " + props.getMinRowCountForPageSizeCheck());
       LOG.info("Max row count for page size check is: " + props.getMaxRowCountForPageSizeCheck());
+      LOG.info("ValueWriterFactory chosen is: " + props.getValuesWriterFactory());
     }
 
     WriteContext init = writeSupport.init(conf);