PARQUET-1049: Make thrift version a property in pom.xml #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is out of date since I just merged #50. I'm also not sure this is worth it, since the version only appears once in the config file. I would support adding it along with a change to verify the version of the thrift executable: apache/parquet-java@a0e6cc3 |
Contributor
Author
|
@rdblue I think it would still make sense since making it a property makes it overridable from the command line as stated in the JIRA. (It could also be used in the 2 exclude expressions.) I'm happy to add a check-thrift-version block as well. |
zivanfi
force-pushed
the
PARQUET-1049
branch
2 times, most recently
from
d68a498 to
7ac7c0b
Compare
Contributor
Author
|
@rdblue Please take a look, I added the thrift version check as you suggested. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.