PARQUET-322 Document ENUM as a logical type. #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
May 9, 2017
| `ENUM` annotates the binary primitive type and indicates that the value | ||
| was converted from an enumarated type in another data model (e.g. Thrift, Avro, Protobuf). | ||
| Applications using a data model lacking a native enum type should interpret `ENUM` | ||
| annotated field as a UTF-8 encoded string. |
Contributor
There was a problem hiding this comment.
What should the ENUM type's sort order be?
Contributor
Author
There was a problem hiding this comment.
I update the commit with the line below.
lekv
requested changes
May 10, 2017
LogicalTypes.md
Outdated
| ### ENUM | ||
|
|
||
| `ENUM` annotates the binary primitive type and indicates that the value | ||
| was converted from an enumarated type in another data model (e.g. Thrift, Avro, Protobuf). |
Contributor
|
LGTM. @rdblue - Do you have more comments? |
Contributor
|
This looks fine to me. @julienledem, any comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.