PARQUET-371: Bumps Thrift version to 0.9.0 #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liancheng
force-pushed
the
parquet-371/thrift9
branch
from
590c68b to
3ec5e5c
Compare
liancheng
changed the title
Contributor
Author
|
Bumped Thrift to the same version used in parquet-mr. However, is there any reason that stops us using the more recent 0.9.2 version in parquet-mr? (0.9.2 was released in 2014, while PARQUET-189 was resolved in Feb 2015.) |
Member
|
This LGTM. @rdblue ? |
Contributor
|
I'm fine with the idea. Have we done any validation to ensure there aren't problems moving to 0.9.0? |
Member
|
Hey. I'd like to bump this up to thrift 0.9.3 since this is the latest. |
Contributor
|
I think this is superseded by PR #50, so we should close it. |
lekv
pushed a commit
to lekv/parquet-format
that referenced
this pull request
Jul 31, 2017
This also changes the compiler options to use only SSE3. We can explore benchmarking to optionally enable SSE4 on supported systems for performance gains in the future. @nongli would it be OK if I remove the unused delta encodings (they depend on code that is not in Impala anymore, or never way)? Are these encodings used extensively, or primarily PLAIN / DICTIONARY encoding? Author: Wes McKinney <[email protected]> Closes apache#31 from wesm/PARQUET-438 and squashes the following commits: df9da64 [Wes McKinney] Add back (commented-out) ZigZig encode/decode impls 65c49bc [Wes McKinney] Fix comment 73c1dc1 [Wes McKinney] Fix cpplint errors post PARQUET-496 553ca0e [Wes McKinney] Fix cpplint errors 9528c83 [Wes McKinney] Updates RLE encoding routines and dependencies from upstream changes in Apache Impala (incubating). Add rle-test and bit-util-test modules unchanged from Impala.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.