Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T2] Wide column metadata improvemnts #253

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions src/main/thrift/parquet.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ enum Encoding {
// GROUP_VAR_INT = 1;

/**
* Deprecated: Dictionary encoding. The values in the dictionary are encoded in the
* DEPRECATED: Dictionary encoding. The values in the dictionary are encoded in the
* plain type.
* in a data page use RLE_DICTIONARY instead.
* in a Dictionary page use PLAIN instead
Expand Down Expand Up @@ -772,15 +772,25 @@ struct PageEncodingStats {
* Description for column metadata
*/
struct ColumnMetaData {
/** Type of this column **/
1: required Type type
/**
* DEPRECATED: can be found in SchemaElement
*
* Writers MUST NOT omit this field until 2025-10-01.
* Readers MUST ignore this field before 2025-10-01.
*/
1: optional Type type

/** Set of all encodings used for this column. The purpose is to validate
* whether we can decode those pages. **/
2: required list<Encoding> encodings

/** Path in schema **/
3: required list<string> path_in_schema
/**
* DEPRECATED: can be found in SchemaElement
*
* Writers MUST NOT omit this field until 2025-10-01.
* Readers MUST ignore this field before 2025-10-01.
*/
3: optional list<string> path_in_schema

/** Compression codec **/
4: required CompressionCodec codec
Expand Down Expand Up @@ -833,6 +843,13 @@ struct ColumnMetaData {
* filter pushdown.
*/
16: optional SizeStatistics size_statistics;

/**
* The index into FileMetadata.schema (list<SchemaElement>) for this column.
* This implies that ColumnMetaData can be sparse in a rowgroup, if for example
* a column does not have any data pages in a rowgroup.
*/
17: optional i32 schema_index;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I accidentally discovered https://issues.apache.org/jira/browse/PARQUET-183 which can be fixed with this field.

}

struct EncryptionWithFooterKey {
Expand Down