-
Notifications
You must be signed in to change notification settings - Fork 464
Closed
Labels
Milestone
Description
PARQUET-369 fixed warnings from shading slf4j-api, but a consequence of shading is that the log messages from thrift for parquet-format classes are dropped. This was an accepted trade-off until PARQUET-305 changed logging in the rest of the library to SLF4J. Now that the slf4j-api is a dependency for all of Parquet except parquet-format, it no longer makes sense to suppress the format thrift logs to avoid exposing it.
This also requires PARQUET-371 because thrift 0.7.0 relies on a very old version of slf4j-api.
Reporter: Ryan Blue / @rdblue
Assignee: Julien Le Dem / @julienledem
Related issues:
- Release Parquet format 2.4.0 (blocks)
- Shading SLF4J prevents SLF4J locating org.slf4j.impl.StaticLoggerBinder (is related to)
- Logger instantiated for package org.apache.parquet may be GC-ed (is related to)
- Bumps Thrift version to 0.9.3 (requires)
- Shutdown hook in parquet-avro library corrupts data and disables logging (is required by)
PRs and other links:
Note: This issue was originally created as PARQUET-412. Please see the migration documentation for further details.