[core] format table: support write file in _temporary at first #6510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Nov 3, 2025
| .filter(c -> c instanceof RenamingTwoPhaseOutputStream.TempFileCommitter) | ||
| .findAny() | ||
| .isPresent()) { | ||
| if (partitionPaths.size() > 1) { |
There was a problem hiding this comment.
You should introduce a clean method to TwoPhaseOutputStream.
JingsongLi
reviewed
Nov 3, 2025
| + commitMessage.getClass().getName()); | ||
| } | ||
| } | ||
| Set<Path> partitionPaths = new HashSet<>(); |
JingsongLi
reviewed
Nov 3, 2025
| public void clean(FileIO fileIO) throws IOException { | ||
| Path path = tempPath.getParent(); | ||
| if (fileIO.exists(path)) { | ||
| fileIO.deleteQuietly(path); |
There was a problem hiding this comment.
Maybe you should use deleteDirectoryQuietly.
jerry-024
force-pushed
the
format_table_rename
branch
from
76a2f00 to
a082b56
Compare
gmdfalk
added a commit
to gmdfalk/paimon
that referenced
this pull request
Nov 5, 2025
* master: (162 commits) [Python] Rename to BATCH_COMMIT_IDENTIFIER in snapshot.py [Python] Suppport multi prepare commit in the same TableWrite (apache#6526) [spark] Fix drop temporary view (apache#6529) [core] skip validate main branch before orphan files cleaning (apache#6524) [core][spark] Introduce upper transform (apache#6521) [Python] Keep the variable names of Identifier consistent with Java (apache#6520) [core] Remove hash lookup to simplify interface (apache#6519) [core][format] Format Table plan partitions should ignore hidden & illegal dirs (apache#6522) [hotfix] Print partition spec and type when error in InternalRowPartitionComputer [hotfix] Add more informat to check partition spec in InternalRowPartitionComputer [hotfix] Use deleteDirectoryQuietly in TempFileCommitter.clean [core] format table: support write file in _temporary at first (apache#6510) [core] Support non null column with write type (apache#6513) [core][fix] Blob with rolling file failed (apache#6518) [core][rest] Support schema validation and infer for external paimon table (apache#6501) [hotfix] Correct visitors for TransformPredicate [hotfix] Rename to copy from withNewInputs in TransformPredicate [core][spark] Support push down transform predicate (apache#6506) [spark] Implement SupportsReportStatistics for PaimonFormatTableBaseScan (apache#6515) [docs] add docs for auto-clustering of historical partitions (apache#6516) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Format table: support write file in _temporary at first
Tests
API and Format
Documentation