-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[core] format table: support file compression and custom default for diff format #6500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jerry-024
wants to merge
6
commits into
apache:master
Choose a base branch
from
jerry-024:format_table_compression
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3d88a09
[core] format table: support file compression and custom default for …
jerry-024 94207bd
add doc
jerry-024 10e1432
Merge branch 'master' into format_table_compression
jerry-024 f781e02
add test for flink
jerry-024 f6e4bc3
fix
jerry-024 269cf64
remove no need code
jerry-024 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ | |
| import org.apache.paimon.CoreOptions; | ||
| import org.apache.paimon.PagedList; | ||
| import org.apache.paimon.Snapshot; | ||
| import org.apache.paimon.TableType; | ||
| import org.apache.paimon.annotation.VisibleForTesting; | ||
| import org.apache.paimon.catalog.Catalog; | ||
| import org.apache.paimon.catalog.CatalogContext; | ||
|
|
@@ -33,6 +34,7 @@ | |
| import org.apache.paimon.fs.Path; | ||
| import org.apache.paimon.function.Function; | ||
| import org.apache.paimon.function.FunctionChange; | ||
| import org.apache.paimon.options.Options; | ||
| import org.apache.paimon.partition.Partition; | ||
| import org.apache.paimon.partition.PartitionStatistics; | ||
| import org.apache.paimon.rest.exceptions.AlreadyExistsException; | ||
|
|
@@ -76,10 +78,13 @@ | |
| import java.util.stream.Collectors; | ||
|
|
||
| import static org.apache.paimon.CoreOptions.BRANCH; | ||
| import static org.apache.paimon.CoreOptions.FORMAT_TABLE_FILE_COMPRESSION; | ||
| import static org.apache.paimon.CoreOptions.PATH; | ||
| import static org.apache.paimon.CoreOptions.TYPE; | ||
| import static org.apache.paimon.catalog.CatalogUtils.checkNotBranch; | ||
| import static org.apache.paimon.catalog.CatalogUtils.checkNotSystemDatabase; | ||
| import static org.apache.paimon.catalog.CatalogUtils.checkNotSystemTable; | ||
| import static org.apache.paimon.catalog.CatalogUtils.getFormatTableFileCompression; | ||
| import static org.apache.paimon.catalog.CatalogUtils.isSystemDatabase; | ||
| import static org.apache.paimon.catalog.CatalogUtils.listPartitionsFromFileSystem; | ||
| import static org.apache.paimon.catalog.CatalogUtils.validateCreateTable; | ||
|
|
@@ -443,6 +448,10 @@ public void createTable(Identifier identifier, Schema schema, boolean ignoreIfEx | |
| checkNotSystemTable(identifier, "createTable"); | ||
| validateCreateTable(schema); | ||
| createExternalTablePathIfNotExist(schema); | ||
| if (Options.fromMap(schema.options()).get(TYPE) == TableType.FORMAT_TABLE) { | ||
|
||
| String fileCompression = getFormatTableFileCompression(schema.options()); | ||
| schema.options().put(FORMAT_TABLE_FILE_COMPRESSION.key(), fileCompression); | ||
| } | ||
| api.createTable(identifier, schema); | ||
| } catch (AlreadyExistsException e) { | ||
| if (!ignoreIfExists) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge
getFormatTableFileCompression.